-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(secretsmanager): add grantUpdate method #8600
feat(secretsmanager): add grantUpdate method #8600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @ialford !
Can I propose a slightly different take on this? Can you add 'secretsmanager:UpdateSecret'
permission to the existing grantWrite()
method, instead of a creating new one?
Thanks,
Adam
Sure, no problem. I wasn't sure which was the better route to take, as I could see use cases for both. I'll push up a revision soon. |
I've updated as requested. Feel free to review when able. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @ialford !
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This method does not exist. This mention in the docs is leftover from an abandoned approach in #8600 and should have been reverted. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This method does not exist. This mention in the docs is leftover from an abandoned approach in aws#8600 and should have been reverted. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This creates the
grantUpdate
method to give aniam.IGrantable
the ability to update a secret in Secrets Manager.I opted to move it out from the
grantWrite
method, as there may be cases where we want something to write an initial value, but not change it later on. This decision could be reversed if it seems too granular or too much of an edge-case.Closes #8491
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license