Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET generation needs to use full type names for reused names cross-construct. #802

Closed
costleya opened this issue Sep 28, 2018 · 3 comments
Labels
bug This issue is a bug. language/dotnet Related to .NET bindings

Comments

@costleya
Copy link
Contributor

Names can be re-used across packages. Full type names need to be used to protect against naming conflicts.

See #786

@costleya costleya added bug This issue is a bug. language/dotnet Related to .NET bindings labels Sep 28, 2018
@RomainMuller
Copy link
Contributor

The generated Java code uses fully qualified names for everything... Should the C# generator do the same?

@mpiroc
Copy link
Contributor

mpiroc commented Sep 28, 2018

The C# Generator attempts to detect whether a fully qualified name is necessary. See SymbolMap. I would start there when searching for the root cause.

Also, should this be moved to the jsii repo?

@RomainMuller
Copy link
Contributor

@mpiroc you're absolutely right - I've created aws/jsii#252 to track this. Resolving here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. language/dotnet Related to .NET bindings
Projects
None yet
Development

No branches or pull requests

3 participants