fix(ecs): default Service throws in a VPC without private subnets #7188
+31
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People like to create VPCs without private subnets, as the NAT gateways (or NAT instances) can be expensive. The default settings of an ECS Service to to create themselves in a PRIVATE subnet, instead of the "default selection order" of Private -> Isolated -> Public. Now use the default selection (by not supplying a `subnetType` at all). Fixes #7062.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
approved these changes
Apr 6, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
horsmand
pushed a commit
to horsmand/aws-cdk
that referenced
this pull request
Apr 8, 2020
…s#7188) People like to create VPCs without private subnets, as the NAT gateways (or NAT instances) can be expensive. The default settings of an ECS Service is to create themselves in a PRIVATE subnet, instead of the "default selection order" of Private -> Isolated -> Public. Now use the default selection (by not supplying a `subnetType` at all). Fixes aws#7062.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
People like to create VPCs without private subnets, as the NAT
gateways (or NAT instances) can be expensive.
The default settings of an ECS Service is to create themselves
in a PRIVATE subnet, instead of the "default selection order" of
Private -> Isolated -> Public. Now use the default selection
(by not supplying a
subnetTypeat all).Fixes #7062.
End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license