Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-kinesis): test assume order between stacks #7065

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

NetaNir
Copy link
Contributor

@NetaNir NetaNir commented Mar 30, 2020

Commit Message

Since StackA and StackB do not have a parent child relation, we can't assume StackB will be prepared before StackA.

End Commit Message


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@NetaNir NetaNir requested a review from shivlaks March 30, 2020 01:08
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 30, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c8a32dd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this currently causing any failures?

@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 17aab37 into master Mar 30, 2020
@mergify mergify bot deleted the neta/fix-kinesis-test branch March 30, 2020 05:22
@NetaNir
Copy link
Contributor Author

NetaNir commented Mar 30, 2020

is this currently causing any failures?

currently no but it might if we change the order of prepare so I thought we can prevent it (not future proofing!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants