Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cfnspec): cloudformation spec v11.6.0 #6995

Merged
merged 9 commits into from
Mar 30, 2020
Merged

feat(cfnspec): cloudformation spec v11.6.0 #6995

merged 9 commits into from
Mar 30, 2020

Conversation

aws-cdk-automation
Copy link
Collaborator

see CHANGELOG

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ebb863d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shivlaks shivlaks added the pr/do-not-merge This PR should not be merged at this time. label Mar 29, 2020
@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 987aa6f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 23cb174
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c7390f2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 237d682
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 44b2117
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shivlaks shivlaks requested a review from eladb March 30, 2020 10:38
@shivlaks
Copy link
Contributor

A couple changes made beyond the automated commit:

@shivlaks shivlaks requested a review from rix0rrr March 30, 2020 10:43
RomainMuller
RomainMuller previously approved these changes Mar 30, 2020
View reviewed changes
@mergify mergify bot dismissed RomainMuller’s stale review March 30, 2020 15:12

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 92461dd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shivlaks shivlaks removed the pr/do-not-merge This PR should not be merged at this time. label Mar 30, 2020
@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 2001e63
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9a552c2 into master Mar 30, 2020
@mergify mergify bot deleted the bump/11.6.0 branch March 30, 2020 17:30
@kawamoto kawamoto mentioned this pull request Apr 2, 2020
Closed
5 tasks
This was referenced Aug 23, 2021
Closed
Merged
mergify bot pushed a commit that referenced this pull request Aug 24, 2021
@madeline-k
fix(resourcegroups): ResourceGroup not using TagType.STANDARD, causes…
cdee1af 
… deploy failure (#16211)

This PR removes a patch to the cloudformation spec that is no longer necessary. Without the patch, the correct tag type of STANDARD is generated for CfnResourceGroup.

PR where the patch was introduced: #6995

Closes #12986 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@madeline-k @hollanddd
fix(resourcegroups): ResourceGroup not using TagType.STANDARD, causes…
3660133 
… deploy failure (aws#16211)

This PR removes a patch to the cloudformation spec that is no longer necessary. Without the patch, the correct tag type of STANDARD is generated for CfnResourceGroup.

PR where the patch was introduced: aws#6995

Closes aws#12986 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
@madeline-k @TikiTDO
fix(resourcegroups): ResourceGroup not using TagType.STANDARD, causes…
a684cd5 
… deploy failure (aws#16211)

This PR removes a patch to the cloudformation spec that is no longer necessary. Without the patch, the correct tag type of STANDARD is generated for CfnResourceGroup.

PR where the patch was introduced: aws#6995

Closes aws#12986 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
@madeline-k @david-doyle-as24
fix(resourcegroups): ResourceGroup not using TagType.STANDARD, causes…
7ba828f 
… deploy failure (aws#16211)

This PR removes a patch to the cloudformation spec that is no longer necessary. Without the patch, the correct tag type of STANDARD is generated for CfnResourceGroup.

PR where the patch was introduced: aws#6995

Closes aws#12986 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

@eladb eladb Awaiting requested review from eladb

@rix0rrr rix0rrr Awaiting requested review from rix0rrr

Assignees

@shivlaks shivlaks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aws-cdk-automation @shivlaks @RomainMuller