-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prlinter): support exempting checks from pr based on a label #6693
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
1 similar comment
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Its sometimes ok to push
feat
commits that don't require a README change, for example: #6691. It also sometimes ok (though not ideal) to pushfeat
commits without a test, for example: #6693.This is mostly true for commits to non construct library modules, e.g
core
,assert
,prlinter
...This PR adds ability to to label PR's with specific labels that instruct our linter to exempt the PR from various checks:
pr-linter/exempt-readme
- Will not require README changes.pr-linter/exempt-test
- Will not require test changes.Caveat
The linter is currently triggered only on PR creation and new commits. This means that if you add one of these labels post PR creation, you will need to push a dummy commit to re-run the linter.
We don't want the linter to run on label assignments because it will cause duplicate checks and screw up mergify.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license