Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IService instead of BaseService in EcsDeployActionProps? #6408

Closed
atsushi-ishibashi opened this issue Feb 23, 2020 · 2 comments
Closed
Assignees
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline @aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug. in-progress This issue is being actively worked on.

Comments

@atsushi-ishibashi
Copy link
Contributor

❓ General Issue

To construct EcsDeployAction, we need BaseService for EcsDeployActionProps.

Type 'IEc2Service' is missing the following properties from type 'BaseService': connections, serviceName, taskDefinition, cluster, and 31 more.

The Question

Following the flow in management console, IService is better than BaseService?
I hope you can set it like below.

const service = ecs.Ec2Service.fromEc2ServiceArn(stack, `service`, serviceArn)
const action = new codepipeline_actions.EcsDeployAction({
  actionName: 'ECS',
  service,
});

Environment

  • CDK CLI Version: 1.25.0
  • Module Version:
  • OS:
  • Language: TypeScript

Other information

@atsushi-ishibashi
Copy link
Contributor Author

The service cannot be defined uniquely by ARN 🤔

@SomayaB SomayaB added @aws-cdk/aws-ecs Related to Amazon Elastic Container in-progress This issue is being actively worked on. labels Feb 24, 2020
@SomayaB SomayaB added bug This issue is a bug. and removed needs-triage This issue or PR still needs to be triaged. labels Feb 24, 2020
@SomayaB SomayaB added the @aws-cdk/aws-codepipeline Related to AWS CodePipeline label Mar 24, 2020
@SomayaB SomayaB assigned skinny85 and unassigned SoManyHs and piradeepk Mar 24, 2020
@skinny85
Copy link
Contributor

Done in #6412 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline @aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug. in-progress This issue is being actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants