Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature flags to cdk doctor #5627

Closed
2 tasks
eladb opened this issue Jan 3, 2020 · 2 comments
Closed
2 tasks

Add feature flags to cdk doctor #5627

eladb opened this issue Jan 3, 2020 · 2 comments
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI

Comments

@eladb
Copy link
Contributor

eladb commented Jan 3, 2020

Use Case

In order to ensure that support personnel can reproduce issues, we would like to include the set of active feature flags when bugs are reported.

See Feature Flags RFC.

Proposed Solution

To that end, we should include the set of feature flags in the output of cdk doctor and also update our bug issue template to request that users will paste the output of it when they submit bug reports.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@eladb eladb added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 3, 2020
@eladb eladb changed the title Add feature flags to cdk doctor and update issue template Add feature flags to cdk doctor Jan 3, 2020
@eladb eladb mentioned this issue Jan 3, 2020
Closed
9 tasks
@SomayaB SomayaB added package/tools Related to AWS CDK Tools or CLI and removed needs-triage This issue or PR still needs to be triaged. labels Jan 6, 2020
@shivlaks
Copy link
Contributor

this might address my comment in #5834
I agree there should be an easier way to look up the feature flags that are in play. I also think it makes sense to exclude feature flags from cdk context

thoughts?

@shivlaks shivlaks added the effort/small Small work item – less than a day of effort label Jan 23, 2020
@shivlaks shivlaks mentioned this issue Jan 28, 2020
Closed
@shivlaks shivlaks added the p2 label Aug 7, 2020
@NGL321 NGL321 assigned rix0rrr and unassigned shivlaks Jan 25, 2021
@rix0rrr rix0rrr removed their assignment Jun 3, 2021
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 3, 2022
@github-actions github-actions bot closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rix0rrr @eladb @SomayaB @shivlaks