Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reference topic titles consistent #501

Closed
Doug-AWS opened this issue Aug 3, 2018 · 9 comments
Closed

Make reference topic titles consistent #501

Doug-AWS opened this issue Aug 3, 2018 · 9 comments
Labels
docs/generated Related to the generated API Reference documentation

Comments

@Doug-AWS
Copy link
Contributor

Doug-AWS commented Aug 3, 2018

We decided that all module README files should have an "H1" with the short service name only:

e.g.

# Amazon ECS
@Rukenshia
Copy link
Contributor

I'd like to update this, what is the preferred naming @Doug-AWS ?

@Doug-AWS
Copy link
Contributor Author

Doug-AWS commented Oct 2, 2018

Start with the official short name, which you can get from https://docs.aws.amazon.com/index.html#lang/en_us, such as "Amazon API Gateway". Then append "Construct Library". So EC2 should be "Amazon EC2 Construct Library".

@eladb
Copy link
Contributor

eladb commented Oct 2, 2018

Let's also change all READMEs to use H1 ("#") instead of H2 ("##") for the title.

At the moment, the first heading in all our READMEs is H2 ("##"), and this is merged into the Sphinx topic with the reference documentation.

The H1 of the topic is set to the module name by default, but now the result is weird, because we have two consecutive headings at the beginning of each topic (H1 with the module name, i.e. "@aws-cdk/aws-s3" and and H2 with the heading from the README (i.e. "AWS S3 Construct Library").

We have recently changed how jsii-sphinx works. If the first line of the README file is an H1 (starts with "# "), it will use this as the first header of the topic instead of the module name.

This means that if we change all README files to use an H1 instead of H2, those titles will be used as the topic names. And I think that makes more sense then the JavaScript module name (esp. given our cross language nature).

Since these topic names are going to appear in the side-bar of our docs website, they should be concise, so I suggest just use the name of the service ("Amazon EC2") for those.

Thoughts?

@Doug-AWS Doug-AWS added the docs/generated Related to the generated API Reference documentation label Jan 23, 2019
@Doug-AWS
Copy link
Contributor Author

Any progress?

@Rukenshia
Copy link
Contributor

Sorry, I didn't have time to pick this item up again and probably won't anytime soon.

@Doug-AWS
Copy link
Contributor Author

Doug-AWS commented Feb 5, 2019

I don't see this as a P0 or even P1. I'm closing and we can worry about the "nice to have" stuff later.

@Doug-AWS Doug-AWS closed this as completed Feb 5, 2019
@eladb
Copy link
Contributor

eladb commented Feb 5, 2019

This is about the README file headings, reopening. We do need to make them consistent.

@eladb eladb reopened this Feb 5, 2019
@Doug-AWS
Copy link
Contributor Author

Doug-AWS commented Feb 5, 2019

I'll try to tackle the headings as I start pulling the info from the readmes as examples. How's that sound? For the existing readmes, that's ECS, CodePipeline, CodeBuild, CodeCommit, so I'll have a PR for those (if they need changing) by EOW.

@ghost
Copy link

ghost commented Aug 7, 2019

Can this be closed?

@eladb eladb closed this as completed Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs/generated Related to the generated API Reference documentation
Projects
None yet
Development

No branches or pull requests

3 participants