Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect example of SNS Lambda subscription #4879

Closed
ovchinnikov opened this issue Nov 6, 2019 · 2 comments · Fixed by #5060
Closed

Incorrect example of SNS Lambda subscription #4879

ovchinnikov opened this issue Nov 6, 2019 · 2 comments · Fixed by #5060
Assignees
@rix0rrr
Labels
@aws-cdk/aws-sns Related to Amazon Simple Notification Service bug This issue is a bug. docs/generated Related to the generated API Reference documentation in-progress This issue is being actively worked on. p2

Comments

@ovchinnikov
Copy link

Hi! It seems that method sns.Topic.subscribeLambda was removed in this PR but example from documentation use old way to configure lambda subscription
@ovchinnikov ovchinnikov added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 6, 2019
@SomayaB SomayaB added @aws-cdk/aws-sns Related to Amazon Simple Notification Service docs/generated Related to the generated API Reference documentation labels Nov 6, 2019
@SomayaB SomayaB added bug This issue is a bug. and removed feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 6, 2019
@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 7, 2019

Good call.

The example can be found here. Could you see your way to correcting it?

https://github.com/aws/aws-cdk/edit/master/packages/@aws-cdk/aws-sns/README.md

Thanks!

@rix0rrr rix0rrr added the p2 label Nov 7, 2019
@hong823
Copy link
Contributor

hong823 commented Nov 16, 2019

Created PR #5060 for the fix.

@hong823 hong823 mentioned this issue Nov 16, 2019
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Nov 18, 2019
@mergify mergify bot closed this as completed in #5060 Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-sns Related to Amazon Simple Notification Service bug This issue is a bug. docs/generated Related to the generated API Reference documentation in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(docs): subscribeLambda method no longer exists hong823/aws-cdk
4 participants
@rix0rrr @ovchinnikov @hong823 @SomayaB