Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #433

Merged
merged 6 commits into from
Jul 31, 2018
Merged

Update README #433

merged 6 commits into from
Jul 31, 2018

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jul 30, 2018

  • Add introductory paragraph about CDK components and usage.
  • Move manual installation instructions to separate file; this is
    no longer on the typical user experience path.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

- Add introductory paragraph about CDK components and usage.
- Move manual installation instructions to separate file; this is
  no longer on the typical user experience path.
@rix0rrr rix0rrr requested review from RomainMuller and eladb July 30, 2018 13:54

You can either download the zip file from the
[Releases](http://github.com/awslabs/aws-cdk/releases) page on GitHub or if you
prefer, download them bits from S3 using the URL provided by our team.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the S3 part, we will no longer publish to S3 after we go public

aws s3 cp <s3-url> ~/aws-cdk.zip
```

## General Hints
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hints?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, "hints" is maybe not the right word. But I want to give a couple of sentences of "goal" introduction for people who more or less understand what is going to happen, before moving to the a step-by-step-here-is-every-line-you-type style instructions.

Conceptually, what you're doing is very simple, but it might look complicated because of the giant list of instructions.

README.md Outdated
@@ -4,7 +4,11 @@

The **AWS Cloud Development Kit (AWS CDK)** is an infrastructure modeling framework that allows you to define your cloud resources using an imperative programming interface. The CDK is currently in developer preview. We look forward to community feedback and collaboration.

## Getting Started
You can use the CDK to define your cloud architecture in code, by composing and creating reusable cloud components called *constructs*. You build your application using the *AWS CDK Construct Library*, a set of classes that encompass all of AWS' services, and then use the *CDK Toolkit* command-line interface to run your program, convert your code to a CloudFormation template, and execute the deployment. Underneath it all is the *CDK Framework* which defines the APIs for the various components.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, this sentence is a bit long and convoluted, how about something like this:

Developers can use one of the supported programming languages to define reusable cloud components called constructs, which are composed together into Stacks and Apps. Apps are synthesized to AWS CloudFormation Templates and deployed to the AWS Cloud using the CDK Command Line Toolkit.

The CDK is shipped with a rich library of constructs called the AWS Construct Library, which includes constructs for all AWS services.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...into Stacks and Apps. Apps are synthesized to...

As a new user reading this: "Ok, so what are Stacks?"

README.md Outdated
@@ -15,74 +19,25 @@ Make sure you have the following prerequisites installed:
* The development toolchain of the language you intend to use (TypeScript,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the line about the development toolchain, it's completely unneeded

README.md Outdated
Add-Content -Path $PROFILE -Value '$env:Path = "$env:Path;$env:UserProfile\.cdk\node_modules\.bin"'
Set-ExecutionPolicy Unrestricted
& $PROFILE
npm install -g aws-cdk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not only for TypeScript.

I would also add a code snippet here until we have the screencast. Also, I would add one line before each command explaining what it does:

Something like:

Initialize an empty CDK project in one of the supported languages:

cdk init app --language typescript # or java

Define your cloud application in code:

<code snippet>

Build & deploy to the AWS Cloud:

cdk deploy


## General Hints

We recommend you extract the package to `~/.cdk`. When using the manual installation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm a new user and I read this, I think "Will something go wrong if I extract to somewhere else?" Maybe something like "Extract the package to a folder on your machine (in the examples, we extracted to ~/.cdk).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work. y-npm will only work if the files are in that location, if I'm not mistaken.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No- y-npm searches relative to where it is installed in + from where it is invoked from. You can extract wherever you like... the CDK toolkit May have a couple of things that expect it to be in ~/.cdk but those can be overridden by setting CDK_HOME (but could be such toolkit stuff actually no longer exist at all)

README.md Outdated
@@ -4,7 +4,11 @@

The **AWS Cloud Development Kit (AWS CDK)** is an infrastructure modeling framework that allows you to define your cloud resources using an imperative programming interface. The CDK is currently in developer preview. We look forward to community feedback and collaboration.

## Getting Started
You can use the CDK to define your cloud architecture in code, by composing and creating reusable cloud components called *constructs*. You build your application using the *AWS CDK Construct Library*, a set of classes that encompass all of AWS' services, and then use the *CDK Toolkit* command-line interface to run your program, convert your code to a CloudFormation template, and execute the deployment. Underneath it all is the *CDK Framework* which defines the APIs for the various components.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...into Stacks and Apps. Apps are synthesized to...

As a new user reading this: "Ok, so what are Stacks?"

@eladb eladb merged commit cdf92d1 into master Jul 31, 2018
@rix0rrr rix0rrr deleted the huijbers/readme branch August 7, 2018 10:50
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants