Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(route53): use static s3 website endpoint #4250

Merged
merged 4 commits into from
Sep 26, 2019
Merged

fix(route53): use static s3 website endpoint #4250

merged 4 commits into from
Sep 26, 2019

Conversation

nmussy
Copy link
Contributor

@nmussy nmussy commented Sep 26, 2019 •
edited
Loading

DnsName shouldn't target the bucket website domain name.
Instead, DnsName must point to the region-wide S3 endpoint,
and the bucket name must match the full DNS record

  • Replace bucketWebsiteDomainName with s3StaticWebsiteEndpoint
  • Document "Bucket name must match the full DNS name"

Fixes #4248

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@nmussy nmussy requested a review from shivlaks as a code owner September 26, 2019 09:06
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

nmussy
nmussy commented Sep 26, 2019
View reviewed changes
packages/@aws-cdk/aws-route53-targets/README.md
@@ -48,5 +41,26 @@ This library contains Route53 Alias Record targets for:
// or - route53.RecordTarget.fromAlias(new alias.ApiGatewayDomainName(domainName)),
});
```
* S3 Bucket WebSite:

**Important:** The Bucket name must strictly match the full DNS name.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to further improve the user experience and check in aws-route53 that the Bucket name matches RecordSet and HostedZone. How do you guys feel about that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make another PR for it 👍

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide some more details in the PR description. For bugs it should include the problem and the solution.

packages/@aws-cdk/aws-route53-targets/README.md
@@ -48,5 +41,26 @@ This library contains Route53 Alias Record targets for:
// or - route53.RecordTarget.fromAlias(new alias.ApiGatewayDomainName(domainName)),
});
```
* S3 Bucket WebSite:

**Important:** The Bucket name must strictly match the full DNS name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3c252c4 into aws:master Sep 26, 2019
@nmussy nmussy mentioned this pull request Sep 26, 2019
Closed
@nmussy nmussy deleted the 4248 branch September 26, 2019 13:23
@nmussy
Copy link
Contributor Author

nmussy commented Sep 26, 2019

Thanks for the quick response @eladb 👍

alukach pushed a commit to alukach/aws-cdk that referenced this pull request Nov 1, 2019
@alukach
fix(route53): use static s3 website endpoint (aws#4250)
58eff81 
* fix(route53): use static s3 website endpoint

* chore: detailed s3 target example

* chore: match test bucketName with generated records
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

@shivlaks shivlaks Awaiting requested review from shivlaks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route 53: Target S3 Alias shouldn't target a bucket
3 participants
@nmussy @aws-cdk-automation @eladb