-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(s3-deployment): allow specifying memory limit #4204
Conversation
when deploying large files, users may need to increase the resource handler's memory configuration. note: since custom resource handlers are singletons, we need to provision a handler for each memory configuration defined in the app. we do this by simply adding a suffix to the uuid of the singleton resource that includes the memory limit. fixes #4058
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
packages/@aws-cdk/aws-s3-deployment/test/test.bucket-deployment.ts
Outdated
Show resolved
Hide resolved
Thank you for contributing! Your pull request is now being automatically merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
I was deploying a web site that grew so that I had this issue. When I updated memoryLimit: 256, XXX/DeployWithInvalidation/CustomResource/Default (XXXDeployWithInvalidationCustomResource4FB1CEFA) Modifying service token is not allowed. Does this mean that once you have set a limit it cannot be changed. |
when deploying large files, users may need to increase the resource handler's memory configuration.
note: since custom resource handlers are singletons, we need to provision a handler for each memory configuration defined in the app. we do this by simply adding a suffix to the uuid of the singleton resource that includes the memory limit.
fixes #4058
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license