Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eks): upgrade latest kubertenes version to 1.14 #4157

Merged
merged 10 commits into from
Sep 23, 2019
Merged

feat(eks): upgrade latest kubertenes version to 1.14 #4157

merged 10 commits into from
Sep 23, 2019

Conversation

nmussy
Copy link
Contributor

@nmussy nmussy commented Sep 19, 2019

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@nmussy nmussy requested a review from eladb as a code owner September 19, 2019 08:47
@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@nmussy
Copy link
Contributor Author

nmussy commented Sep 19, 2019

EKS added Kubernetes 1.14 support earlier this month.

I've only bumped the constant without adding the AMIs to the static table, waiting for SSM support to be merged (#4156)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb previously approved these changes Sep 19, 2019
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@nmussy
Copy link
Contributor Author

nmussy commented Sep 19, 2019

@eladb Is too late to block it now? I wanted to wait until #4156 was merged

@eladb eladb added the pr/do-not-merge This PR should not be merged at this time. label Sep 19, 2019
@eladb
Copy link
Contributor

eladb commented Sep 19, 2019

Let’s see...

@nmussy
Copy link
Contributor Author

nmussy commented Sep 19, 2019

I should have made a draft, sorry about that. I'm making the changes to #4156 now anyway

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb eladb removed the pr/do-not-merge This PR should not be merged at this time. label Sep 23, 2019
@mergify mergify bot dismissed eladb’s stale review September 23, 2019 11:59

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb reviewed Sep 23, 2019
View reviewed changes
scripts/kube_bump.sh Outdated
@@ -0,0 +1,21 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this under packages/@aws-cdk/aws-eks/scripts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♥️

@mergify mergify bot merged commit c7def91 into aws:master Sep 23, 2019
eladb pushed a commit that referenced this pull request Sep 23, 2019
feat(eks): upgrade latest kubertenes version to 1.14 (#4157)
73c6f9c 
* feat(eks): upgrade latest kubertenes version to 1.14

* fix: bump version in new cluster file

* chore: bump ssm optimized-amis versions

* chore: update imageId refs

* feat: add scripts/kube_bump

* chore: move kube_bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@eladb eladb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmussy @aws-cdk-automation @eladb