Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): stack.templateFile #3808

Merged
merged 3 commits into from
Aug 27, 2019
Merged

feat(core): stack.templateFile #3808

merged 3 commits into from
Aug 27, 2019

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Aug 27, 2019 •
edited
Loading

When integrating CDK with CI/CD systems, it is often required to know the name of the template file as emitted to the cloud assembly. This change adds stack.templateFile which can be used to query this information instead of by-convention.

Fixes #3807

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Elad Ben-Israel added 2 commits August 27, 2019 14:22
feat(eks): updated AMI and EC2 instance sizes
9dff377 
Also, create a script that downloads and generates the updated
instance data. �It needs to be executed manually every time we want
to update instance data, but still...

Fixes #3751
feat(core): stack.templateFile
fb6ed5d 
Expose the name of the template file as emitted to the cloud assembly.

Fixes #3807
@eladb eladb changed the title Benisrae/template file feat(core): stack.templateFile Aug 27, 2019
@eladb eladb requested a review from rix0rrr August 27, 2019 11:51
@eladb eladb self-assigned this Aug 27, 2019
@eladb eladb merged commit ac54e14 into master Aug 27, 2019
@eladb eladb deleted the benisrae/template-file branch August 27, 2019 12:28
@eladb
Copy link
Contributor Author

eladb commented Aug 27, 2019 •
edited
Loading

Copy @NetaNir

@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 23, 2019
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@eladb eladb

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stack.templateFile
3 participants
@eladb @rix0rrr @NGL321