-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(acm): validated certificate can use existing Role #3785
Conversation
Pull Request Checklist
|
// GIVEN | ||
const app = new App(); | ||
const stack = new Stack(app, 'Stack', { | ||
env: { account: '12345678', region: 'us-blue-5' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason not to use a 12 digit placeholder account id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not particularly.
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
Allow specifying an existing Role for the Validated Certificate,
to remove the dependency on
iam:CreateRole
.Fixes #3519, but needs implementation of #3753 for maximum usefulness.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license