Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(acm): validated certificate can use existing Role #3785

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Aug 26, 2019

Allow specifying an existing Role for the Validated Certificate,
to remove the dependency on iam:CreateRole.

Fixes #3519, but needs implementation of #3753 for maximum usefulness.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Allow specifying an existing Role for the Validated Certificate,
to remove the dependency on `iam:CreateRole`.

Fixes #3519, but needs implementation of #3753 for maximum usefulness.
@rix0rrr rix0rrr self-assigned this Aug 26, 2019
@mergify
Copy link
Contributor

mergify bot commented Aug 26, 2019

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

// GIVEN
const app = new App();
const stack = new Stack(app, 'Stack', {
env: { account: '12345678', region: 'us-blue-5' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not to use a 12 digit placeholder account id?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not particularly.

@rix0rrr rix0rrr merged commit b51723c into master Aug 27, 2019
@rix0rrr rix0rrr deleted the huijbers/acm-imported-role branch August 27, 2019 08:02
@rix0rrr rix0rrr added review/small effort/small Small work item – less than a day of effort and removed review/small labels Sep 16, 2019
@mergify
Copy link
Contributor

mergify bot commented Sep 16, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DnsValidatedCertificate requires the excessive iam:CreateRole Action
3 participants