Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events): add target to make AWS API calls #3720

Merged
merged 10 commits into from
Aug 27, 2019

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Aug 20, 2019

Add a AwsApi rule target to make AWS API calls.

Comparable to the AwsCustomResource in terms of API and IAM permissions.

Closes #2538


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Add a `AwsApi` rule target to make AWS API calls.

Comparable to the `AwsCustomResource` in terms of API and IAM permissions.

Closes aws#2538
@mergify
Copy link
Contributor

mergify bot commented Aug 20, 2019

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

@jogold
Copy link
Contributor Author

jogold commented Aug 20, 2019

See integ test for usage examples.

@mergify
Copy link
Contributor

mergify bot commented Aug 20, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

packages/@aws-cdk/aws-events/README.md Outdated Show resolved Hide resolved
eladb
eladb previously requested changes Aug 26, 2019
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Update README

@mergify mergify bot dismissed eladb’s stale review August 26, 2019 13:16

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Aug 26, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify
Copy link
Contributor

mergify bot commented Aug 26, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@eladb eladb changed the title feat(event-targets): add target to make AWS API calls feat(events): add target to make AWS API calls Aug 27, 2019
@eladb eladb merged commit b6f055a into aws:master Aug 27, 2019
@jogold jogold deleted the aws-lambda-event-target branch September 2, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a construct to make/schedule AWS API calls
2 participants