feat(bootstrap): add kms option to cdk bootstrap #3634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
reviewed
Aug 13, 2019
packages/aws-cdk/bin/cdk.ts
Outdated
| @@ -51,13 +51,14 @@ async function parseCommandLineArguments() { | |||
| .command([ 'synthesize [STACKS..]', 'synth [STACKS..]' ], 'Synthesizes and prints the CloudFormation template for this stack', yargs => yargs | |||
| .option('exclusively', { type: 'boolean', alias: 'e', desc: 'only deploy requested stacks, don\'t include dependencies' })) | |||
| .command('bootstrap [ENVIRONMENTS..]', 'Deploys the CDK toolkit stack into an AWS environment', yargs => yargs | |||
| .option('toolkit-bucket-name', { type: 'string', alias: 'b', desc: 'The name of the CDK toolkit bucket', default: undefined })) | |||
| .option('toolkit-bucket-name', { type: 'string', alias: 'b', desc: 'The name of the CDK toolkit bucket', default: undefined }) | |||
| .option('toolkit-bucket-kms-key-id', { type: 'string', desc: 'AWS KMS master key ID used for the SSE-KMS encryption', default: undefined })) | |||
There was a problem hiding this comment.
add --bootstrap-bucket-name as an alias to --toolkit-bucket-name
There was a problem hiding this comment.
How can I add a second alias to --toolkit-bucket-name?
There was a problem hiding this comment.
I think there should be an .alias() method
eladb
reviewed
Aug 13, 2019
packages/aws-cdk/bin/cdk.ts
Outdated
| @@ -51,7 +51,7 @@ async function parseCommandLineArguments() { | |||
| .command([ 'synthesize [STACKS..]', 'synth [STACKS..]' ], 'Synthesizes and prints the CloudFormation template for this stack', yargs => yargs | |||
| .option('exclusively', { type: 'boolean', alias: 'e', desc: 'only deploy requested stacks, don\'t include dependencies' })) | |||
| .command('bootstrap [ENVIRONMENTS..]', 'Deploys the CDK toolkit stack into an AWS environment', yargs => yargs | |||
| .option('toolkit-bucket-name', { type: 'string', alias: 'b', desc: 'The name of the CDK toolkit bucket', default: undefined }) | |||
| .option('toolkit-bucket-name', { type: 'string', alias: ['b', 'bootstrap-bucket-name'], desc: 'The name of the CDK toolkit bucket', default: undefined }) | |||
There was a problem hiding this comment.
Sorry for being annoying, can you make bootstrap-bucket-name the primary?
There was a problem hiding this comment.
Sure, give me a second. I am fixing the multiple LambdaIntegrations PR currently
eladb
approved these changes
Aug 13, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2203 and supersedes #2245
I had to create a new PR as merging was not easy and I cannot change the other PR
Thanks to @abelmokadem for the work.