Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stepfunctions): support step functions state machine execution from a task state #3522

Merged
merged 3 commits into from
Aug 9, 2019
Merged

feat(stepfunctions): support step functions state machine execution from a task state #3522

merged 3 commits into from
Aug 9, 2019

Conversation

wqzoww
Copy link
Contributor

@wqzoww wqzoww commented Aug 2, 2019 •
edited by eladb
Loading

Step Functions allows to start state machine executions by calling its own API StartExecution as an integrated service. This commit is made to implement this new feature.

The corresponding IAM poliy has been defined and the service principal in the IAM role has been fixed.

Closes #3521

Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@JasonMrX
Copy link

JasonMrX commented Aug 2, 2019

This is great!

@wqzoww
Copy link
Contributor Author

wqzoww commented Aug 3, 2019

I have trouble in verifying the details of CodeBuild failure. The error message is:

The requested content was not found.
The content may no longer exist in this location, or a resource may have been deleted, renamed, or configured with permissions your user could not access.

@skinny85
Copy link
Contributor

skinny85 commented Aug 3, 2019

Here's the error message @wqzoww:

Original assembly: @aws-cdk/[email protected] 
Updated assembly:  @aws-cdk/[email protected] 
API elements with incompatible changes: 
err  - PROP @aws-cdk/aws-events.RuleTargetConfig.targetResource: has been removed [removed:@aws-cdk/aws-events.RuleTargetConfig.targetResource]

It looks like you were extremely unfortunate, and the build ran during our publishing step (as @aws-events 1.3.0 definitely exist).

Can you rebase your change on top of the newest master, and try again? Or just push an empty commit to re-trigger the build, if you're already up-to-date with master.

@eladb eladb changed the title feat(aws-stepfunctions-tasks): support step functions state machine e… feat(stepfunctions): support step functions state machine execution from a task state Aug 7, 2019
@eladb eladb requested a review from rix0rrr August 7, 2019 07:10
@eladb eladb assigned rix0rrr and unassigned eladb Aug 7, 2019
rix0rrr
rix0rrr reviewed Aug 7, 2019
View reviewed changes
packages/@aws-cdk/aws-stepfunctions-tasks/lib/start-execution.ts Outdated
* Pause the workflow until the task token is returned by SendTaskSuccess or SendTaskFailure.
* See {@link https://docs.aws.amazon.com/step-functions/latest/dg/connect-to-resource.html#connect-wait-token|WaitForCallback}
*/
readonly waitForTaskToken?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need an update after #3115 is merged to be consistent.

packages/@aws-cdk/aws-stepfunctions-tasks/lib/start-execution.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/lib/start-execution.ts Show resolved Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/lib/start-execution.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/lib/start-execution.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/lib/start-execution.ts Outdated Show resolved Hide resolved
@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 7, 2019

Happy to ship this in principle after addressing the small syntactic niggles, but probably after #3115 so that we can bring it in line with the invocation style? Or would you prefer I do it immediately?

@wqzoww wqzoww closed this Aug 7, 2019
@wqzoww wqzoww reopened this Aug 7, 2019
@wqzoww
Copy link
Contributor Author

wqzoww commented Aug 7, 2019 •
edited
Loading

Happy to ship this in principle after addressing the small syntactic niggles, but probably after #3115 so that we can bring it in line with the invocation style? Or would you prefer I do it immediately?

I am OK to make the code change once #3115 gets merged.
(Sorry I closed the pull request by accident one minute ago.)

@wqzoww
feat(aws-stepfunctions-tasks): support step functions state machine e…
b2003d8 
…xecution from a task state

Step Functions allows to start state machine executions by calling its own API StartExecution as an integrated service. This commit is made to implement this new feature.

The corresponding IAM poliy has been defined and the service principal in the IAM role has been fixed.

Closes aws#3521
@mergify mergify bot merged commit ac77990 into aws:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-stepfunctions-tasks: manage state machine executions as an integrated service
5 participants
@wqzoww @JasonMrX @skinny85 @rix0rrr @eladb