fix(cognito-identitypool-alpha): prevent stacks from not deploying correctly

[Leo10Gama]

Issue # (if applicable)

Closes #33510

Reason for this change

A previous change (PR33305) removed the IdentityPoolRoleAttachment L2 construct, which also changed the creation logic of the default role attachment in the IdentityPool L2. This not only triggered redeployments, but did not allow for redeployment at all, as the new role attachment (with a different resource hash) was trying to be created before the old one was removed. This led to failed deployments, as only one role attachment can exist per identity pool.

Description of changes

Brought back the IdentityPoolRoleAttachment L2 logic to prevent redeployment for customers using CDK <v2.179.0. However, the construct is now no longer being exported, which preserves the original intention of preventing confusion about using this resource.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

yarn test && yarn integ test/integ.identitypool.js --update-on-failed

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

BREAKING CHANGE: Any IdentityPool resources deployed in versions >=2.179.0 will now fail to deploy. You will need to delete the IdentityPoolRoleAttachment from your stack via the console before redeploying.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

(This review is outdated)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (dd0d62f) to head (a753451).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33609   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files         119      119           
  Lines        6876     6876           
  Branches     1162     1162           
=======================================
  Hits         5653     5653           
  Misses       1120     1120           
  Partials      103      103           

Flag	Coverage Δ
suite.unit	82.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	∅ <ø> (∅)
packages/aws-cdk-lib/core	82.21% <ø> (ø)

[Leo10Gama]

Exemption Request: The snapshot has been updated

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: a753451
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[Leo10Gama]

For the sake of completeness, this avoids redeployments with versions <2.179.0, as the previous PR shows an identical resource name:

identitypoolDefaultRoleAttachment6BCAB114

...which is identical to what these changes result in it being.

[xazhao]

LGTM

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.