Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultChild doesn't work for Autoscaling group #3314

Closed
1 of 5 tasks
SanderKnape opened this issue Jul 16, 2019 · 1 comment
Closed
1 of 5 tasks

defaultChild doesn't work for Autoscaling group #3314

SanderKnape opened this issue Jul 16, 2019 · 1 comment
Assignees
Labels
needs-triage This issue or PR still needs to be triaged.

Comments

@SanderKnape
Copy link

  • I'm submitting a ...

    • πŸͺ² bug report
    • πŸš€ feature request
    • πŸ“š construct library gap
    • ☎️ security issue or vulnerability => Please see policy
    • ❓ support request => Please see note at the top of this template.
  • What is the current behavior?
    If the current behavior is a πŸͺ²bugπŸͺ²: Please provide the steps to reproduce

To get the underlying CFN resource for an Autoscaling group, node.tryFindChild('ASG') must be used instead of node.defaultChild(). This is because "ASG" is used instead of "Resource" within the construct:

this.autoScalingGroup = new CfnAutoScalingGroup(this, 'ASG', asgProps);

  • What is the expected behavior (or behavior of feature suggested)?

To be able to simply use defaultChild.

  • What is the motivation / use case for changing the behavior or adding this feature?

Ideally you wouldn't need access to the underlying CFN resource, but for an autoscaling group there is a use case when using cfn-init as described here: #1413

  • Please tell us about your environment:

    • CDK CLI Version: 1.0.0
    • Module Version: 1.0.0
    • OS: [all]
    • Language: [all ]
@SanderKnape SanderKnape added the needs-triage This issue or PR still needs to be triaged. label Jul 16, 2019
@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 28, 2019

Fixed by #3572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants