AwsCdkCli: cdk deploy tries automatic rollback even when --no-rollback specified

[dsturnbull]

Describe the bug

I run cdk deploy X --no-rollback, and some failure happened. CDK reports:

X: deploying... [1/1]
X: creating CloudFormation changeset...
Stack is in a paused fail state and command line arguments do not include "--no-rollback". Roll back first and then proceed with deployment (y/n)?

Regression Issue

• Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

I believe that if --no-rollback is supplied, automatic rollback should clearly be disabled, and also we should not be presented with an incorrect message

Current Behavior

CDK attempts reports incorrect message

Reproduction Steps

Contrive a non-fatal transient cloudformation error such that you would normally attempt a redeploy after some time.

Possible Solution

Disable automatic rollback if --no-rollback supplied.

Additional Information/Context

No response

CDK CLI Version

2.170.0

Framework Version

No response

Node.js Version

18.20.4

OS

macOS

Language

TypeScript

Language Version

No response

Other information

No response

[rix0rrr]

This should only be able to happen if the --no-rollback flag is ignored altogether. But it doesn't seem to be, right? Normally you are able to perform --no-rollback deployments?

Can you run npx cdk deploy --no-rollback -vvv when this happens again and paste the log?

[rix0rrr]

I was able to repro.

[ashishdhingra]

PR #32309 pending merge.

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.