feat(elasticloadbalancingv2): ip address type for both network and application target group #32189

badmintoncryer · 2024-11-19T15:03:57Z

Issue # (if applicable)

None

Reason for this change

Both Application and Network target group supports for specifying IP address type.

Application: https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-target-groups.html#target-group-ip-address-type
Network: https://docs.aws.amazon.com/elasticloadbalancing/latest/network/load-balancer-target-groups.html#target-group-ip-address-type

Description of changes

Define TargetGroupIpAddressType enum
- Because there has been a IpAddressType in aws-elassticloadbalancingv2 module, I don't name IpAddressType
Add ipAddressType prop to BaseTargetGroupProps

Description of how you validated changes

Add both unit and integ tests.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

badmintoncryer · 2024-11-19T15:05:19Z

packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/shared/base-target-group.ts

@@ -84,7 +106,7 @@ export interface HealthCheck {
   * The approximate number of seconds between health checks for an individual target.
   * Must be 5 to 300 seconds
   *
-   * @default 10 seconds if protocol is `GENEVE`, 35 seconds if target type is `lambda`, else 30 seconds
+   * @default - 10 seconds if protocol is `GENEVE`, 35 seconds if target type is `lambda`, else 30 seconds


I have corrected the usage of hyphens in some @default descriptions. If it is preferable, I can separate this into a different PR.

badmintoncryer · 2024-11-19T15:08:16Z

packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/shared/base-target-group.ts

+  /**
+   * The type of IP addresses of the targets registered with the target group.
+   *
+   * @default undefined - ELB defaults to IPv4


I think @default IPv4 is sufficient, but I have written it this way because several maintainers have recently recommended this approach.

feat(ses): maximum delivery time for emails #32102 (comment)

feat(neptune): auto minor version upgrade for an instance #31988 (comment)

Thanks! I like it this way so that we know both the CDK default behaviour and CFN default behaviour.

codecov · 2024-11-19T15:15:52Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.46%. Comparing base (2eebc59) to head (52da20b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #32189   +/-   ##
=======================================
  Coverage   77.46%   77.46%           
=======================================
  Files         105      105           
  Lines        7168     7168           
  Branches     1314     1314           
=======================================
  Hits         5553     5553           
  Misses       1433     1433           
  Partials      182      182

Flag	Coverage Δ
suite.unit	`77.46% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`77.46% <ø> (ø)`

GavinZZ

LGTM, thanks for your consistent and high-quality contribution.

GavinZZ · 2024-11-25T22:28:50Z

packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/shared/base-target-group.ts

+  /**
+   * The type of IP addresses of the targets registered with the target group.
+   *
+   * @default undefined - ELB defaults to IPv4


Thanks! I like it this way so that we know both the CDK default behaviour and CFN default behaviour.

mergify · 2024-11-25T22:31:20Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2024-11-25T22:36:08Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

badmintoncryer · 2024-11-26T03:19:53Z

@Mergifyio update

mergify · 2024-11-26T03:20:02Z

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/lambda-runtime-tests.yml without workflows permission

badmintoncryer · 2024-11-26T14:34:15Z

@mergify update

mergify · 2024-11-26T14:34:29Z

update

✅ Branch has been successfully updated

mergify · 2024-11-26T15:06:39Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

aws-cdk-automation · 2024-11-26T19:55:35Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 52da20b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-11-26T19:56:08Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2024-11-26T20:50:05Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

badmintoncryer added 3 commits November 19, 2024 23:27

add ip address type

fca6387

add integ test

5e932c9

update readme

8cec025

github-actions bot added the p2 label Nov 19, 2024

aws-cdk-automation requested a review from a team November 19, 2024 15:04

github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Nov 19, 2024

badmintoncryer commented Nov 19, 2024

View reviewed changes

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 19, 2024

badmintoncryer changed the title ~~feat(elasticloadbalancingv2): configure IP address type for both network and application target group~~ feat(elasticloadbalancingv2): ip address type for both network and application target group Nov 20, 2024

Merge branch 'main' into ipv6-nlb-target-group

580337b

mazyu36 approved these changes Nov 25, 2024

View reviewed changes

aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 25, 2024

Merge branch 'main' into ipv6-nlb-target-group

20a1152

GavinZZ previously approved these changes Nov 25, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 25, 2024

Merge branch 'main' into ipv6-nlb-target-group

40be378

Merge branch 'main' into ipv6-nlb-target-group

52da20b

GavinZZ approved these changes Nov 26, 2024

View reviewed changes

mergify bot merged commit 7cc5f30 into aws:main Nov 26, 2024
19 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2024

badmintoncryer deleted the ipv6-nlb-target-group branch November 26, 2024 23:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(elasticloadbalancingv2): ip address type for both network and application target group #32189

feat(elasticloadbalancingv2): ip address type for both network and application target group #32189

badmintoncryer commented Nov 19, 2024

badmintoncryer Nov 19, 2024

badmintoncryer Nov 19, 2024

GavinZZ Nov 25, 2024

codecov bot commented Nov 19, 2024 •

edited

Loading

GavinZZ left a comment

GavinZZ Nov 25, 2024

mergify bot commented Nov 25, 2024

mergify bot commented Nov 25, 2024

badmintoncryer commented Nov 26, 2024

mergify bot commented Nov 26, 2024

badmintoncryer commented Nov 26, 2024

mergify bot commented Nov 26, 2024

mergify bot commented Nov 26, 2024

aws-cdk-automation commented Nov 26, 2024

mergify bot commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

feat(elasticloadbalancingv2): ip address type for both network and application target group #32189

feat(elasticloadbalancingv2): ip address type for both network and application target group #32189

Conversation

badmintoncryer commented Nov 19, 2024

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

badmintoncryer Nov 19, 2024

Choose a reason for hiding this comment

badmintoncryer Nov 19, 2024

Choose a reason for hiding this comment

GavinZZ Nov 25, 2024

Choose a reason for hiding this comment

codecov bot commented Nov 19, 2024 • edited Loading

Codecov Report

GavinZZ left a comment

Choose a reason for hiding this comment

GavinZZ Nov 25, 2024

Choose a reason for hiding this comment

mergify bot commented Nov 25, 2024

mergify bot commented Nov 25, 2024

badmintoncryer commented Nov 26, 2024

mergify bot commented Nov 26, 2024

❌ Mergify doesn't have permission to update

badmintoncryer commented Nov 26, 2024

mergify bot commented Nov 26, 2024

✅ Branch has been successfully updated

mergify bot commented Nov 26, 2024

aws-cdk-automation commented Nov 26, 2024

AWS CodeBuild CI Report

mergify bot commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

codecov bot commented Nov 19, 2024 •

edited

Loading