Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sqs): queue with fifo: false does not deploy #31922

Merged
merged 2 commits into from
Oct 28, 2024
Merged

fix(sqs): queue with fifo: false does not deploy #31922

merged 2 commits into from
Oct 28, 2024

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Oct 28, 2024 •
edited
Loading

The FifoQueue property in CloudFormation can only be true, or must be absent. If you pass FifoQueue: false, you will receive the following error:

Resource handler returned message: "Unknown Attribute FifoQueue.
(Service: Sqs, Status Code: 400, Request ID: e27d9d99-fe35-5b36-b670-c200419bc975)" (RequestToken: 1d882ab3-52e8-7e4b-e2d3-58e6ba10141d, HandlerErrorCode: InvalidRequest)

Make it so that a fifo: false configuration doesn't output FifoQueue at all.

Closes #8550.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr
fix(sqs): Queue with fifo: false does not deploy
982cfb5 
The `FifoQueue` property in CloudFormation can only be `true`, or
must be absent.

Make it so that a `fifo: false` configuration doesn't output FifoQueue
at all.

Closes #8550.
@rix0rrr rix0rrr requested a review from a team October 28, 2024 17:05
@github-actions github-actions bot added bug This issue is a bug. p2 labels Oct 28, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 28, 2024 17:05
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 28, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

kaizencc
kaizencc approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a difficult fix, surely

@kaizencc kaizencc changed the title fix(sqs): Queue with fifo: false does not deploy fix(sqs): queue with fifo: false does not deploy Oct 28, 2024
@kaizencc kaizencc added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Oct 28, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 28, 2024 17:12

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 68570bd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 28, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a9d3b02 into main Oct 28, 2024
12 checks passed
@mergify mergify bot deleted the huijbers/sqs-fifo branch October 28, 2024 18:55
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaizencc kaizencc kaizencc approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQS - Unknown Attribute FifoQueue when setting fifo to false in Queue Props
3 participants
@rix0rrr @aws-cdk-automation @kaizencc