fix(location): remove base class from PlaceIndex class #31287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
distinguished-contributor
aws-cdk-automation
added
the
pr/needs-community-review
| @@ -74,39 +74,12 @@ export enum IntendedUse { | |||
| STORAGE = 'Storage', | |||
| } | |||
|
|
|||
| abstract class PlaceIndexBase extends Resource implements IPlaceIndex { | |||
There was a problem hiding this comment.
@mazyu36 - just to double clarify here, you don't forsee adding an additional class anywhere that would need to extend the base class?
There was a problem hiding this comment.
I don't think we'll need to add other classes, since there are no resources similar to placeindex.
sumupitchayan
changed the title
sumupitchayan
changed the title
sumupitchayan
added
pr-linter/exempt-readme
sumupitchayan
previously approved these changes
Oct 30, 2024
mergify
bot
dismissed
sumupitchayan’s stale review
Pull request has been modified.
sumupitchayan
approved these changes
Oct 30, 2024
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
None
Reason for this change
I implemented the location resources in #30711 and #30682.
During the review, it was suggested that it would be better not to have a base class.
As a result, the
GeofenceCollectionclass andRouteCalculatorclass do not have a base class.#30711 (comment)
On the other hand, the
PlaceIndexclass has already been implemented with a base class, which is inconsistent with the current approach.Description of changes
Remove a unnecessary base class from
PlaceIndexclass.Description of how you validated changes
Re-run unit tests and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license