Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipes-enrichments): add Step Functions enrichment eventbridge pipes #30495

Merged
merged 8 commits into from
Jun 21, 2024

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Jun 9, 2024

Issue # (if applicable)

Closes #29385.

Reason for this change

To use Step Functions state machine enrichment for eventbrige pipes

Description of changes

Add StepFunctionsEnrichment class.

Description of how you validated changes

Add unit test and integ tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Jun 9, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team June 9, 2024 06:11
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Jun 9, 2024
@mazyu36 mazyu36 marked this pull request as draft June 9, 2024 06:15
@mazyu36 mazyu36 marked this pull request as ready for review June 9, 2024 06:21
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 9, 2024
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 Left suggestions for minor adjustments

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 9, 2024
@mazyu36
Copy link
Contributor Author

mazyu36 commented Jun 9, 2024

@lpizzinidev

Thank you always for your reviews!
I've addressed all your comment.

@mazyu36 mazyu36 changed the title feat(pipes-enrichments): add Step Functions enrichmenteventbrige pipes feat(pipes-enrichments): add Step Functions enrichment eventbrige pipes Jun 10, 2024
@mazyu36 mazyu36 changed the title feat(pipes-enrichments): add Step Functions enrichment eventbrige pipes feat(pipes-enrichments): add Step Functions enrichment eventbridge pipes Jun 10, 2024
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 10, 2024
@mazyu36
Copy link
Contributor Author

mazyu36 commented Jun 21, 2024

@GavinZZ
Thank you for the review.
I've replied to your comment.

@mazyu36 mazyu36 requested a review from GavinZZ June 21, 2024 00:04
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Thank you.

Copy link
Contributor

mergify bot commented Jun 21, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 21, 2024
@mazyu36
Copy link
Contributor Author

mazyu36 commented Jun 21, 2024

@Mergifyio update

Copy link
Contributor

mergify bot commented Jun 21, 2024

update

✅ Branch has been successfully updated

Copy link
Contributor

mergify bot commented Jun 21, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 776c7b8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8b495f9 into aws:main Jun 21, 2024
9 of 10 checks passed
Copy link
Contributor

mergify bot commented Jun 21, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mazyu36 mazyu36 deleted the pipes-enrichments-sfn branch June 21, 2024 03:22
sarangarav pushed a commit to sarangarav/aws-cdk that referenced this pull request Jun 21, 2024
…pes (aws#30495)

### Issue # (if applicable)

Closes aws#29385.

### Reason for this change
To use Step Functions state machine enrichment for eventbrige pipes

### Description of changes
Add `StepFunctionsEnrichment` class.

### Description of how you validated changes
Add unit test and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mazyu36 added a commit to mazyu36/aws-cdk that referenced this pull request Jun 22, 2024
…pes (aws#30495)

### Issue # (if applicable)

Closes aws#29385.

### Reason for this change
To use Step Functions state machine enrichment for eventbrige pipes



### Description of changes
Add `StepFunctionsEnrichment` class.



### Description of how you validated changes
Add unit test and integ tests.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(pipes-enrichments): Add Step Functions state machine enrichment for EventBridge pipes
4 participants