Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(pipes-sources): Add SQS queue source for EventBridge pipes #30397

Closed
1 of 2 tasks
Gobbees opened this issue May 31, 2024 · 3 comments
Closed
1 of 2 tasks

(pipes-sources): Add SQS queue source for EventBridge pipes #30397

Gobbees opened this issue May 31, 2024 · 3 comments
Labels
@aws-cdk/aws-sqs Related to Amazon Simple Queue Service feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@Gobbees
Copy link

Gobbees commented May 31, 2024

Describe the feature

Add an implementation for the SQS queue source for EventBridge pipes in the pipes-source module

Use Case

For feature completeness of the L2 pipes module this source is required.

Proposed Solution

A PR has been opened for similar sources (DDB and Kinesis): #29476.

I'd be happy to see how that progresses and build on top of that.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

N/A

Environment details (OS name and version, etc.)

N/A

@Gobbees Gobbees added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 31, 2024
@github-actions github-actions bot added the @aws-cdk/aws-sqs Related to Amazon Simple Queue Service label May 31, 2024
@Gobbees
Copy link
Author

Gobbees commented May 31, 2024

Oh, I just noticed this is already implemented: https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-pipes-sources-alpha/lib/sqs.ts.

Apologies for the churn

@Gobbees Gobbees closed this as completed May 31, 2024
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-sqs Related to Amazon Simple Queue Service feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants