-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imagebuilder.CfnImagePipeline: AWS::ImageBuilder::ImagePipeline WorkflowConfiguration #29910
Comments
This seems to be an issue of CFN not CDK. Can you share the synthesized CFN template of this resource? |
Hi @pahud thank you for picking up this. Here it goes that synth section which looks fine to me. Pipeline:
Type: AWS::ImageBuilder::ImagePipeline
Properties:
Description: Image pipeline
DistributionConfigurationArn:
Fn::GetAtt:
- euAllDistribution
- Arn
EnhancedImageMetadataEnabled: true
ExecutionRole:
Fn::GetAtt:
- EC2InstanceProfileForImageBuilderA043DE9F
- Arn
ImageRecipeArn:
Fn::GetAtt:
- BaseRecipe
- Arn
ImageScanningConfiguration:
ImageScanningEnabled: false
ImageTestsConfiguration:
ImageTestsEnabled: false
TimeoutMinutes: 60
InfrastructureConfigurationArn:
Fn::GetAtt:
- infraConfig
- Arn
Name: pipe-img-builder-x-pipeline
Schedule:
PipelineExecutionStartCondition: EXPRESSION_MATCH_AND_DEPENDENCY_UPDATES_AVAILABLE
ScheduleExpression: cron(0 0 * * ? *)
Status: ENABLED
Tags:
Name: pipe-img-builder
Release: live
Version: 0.1.0
Workflows:
- OnFailure: ABORT
WorkflowArn: arn:aws:imagebuilder:eu-west-1:aws:workflow/build/build-image/1.0.1
Metadata:
aws:cdk:path: PipeImgBuilderStack/Pipeline I've noted that in the main page (AWS Console) / EC2 Image Builder / Image workflows: the 'build-image' has the following "Arn: arn:aws:imagebuilder:eu-west-1:aws:workflow/build/build-image/1.0.1", but if you click "build-image" to see its details, the Arn is: "arn:aws:imagebuilder:eu-west-1:aws:workflow/build/build-image/1.0.1/1". Not much a difference and in fact I've tested both; returns the same error. PS: I can ship the entire synth if you need. Thank you in advance, |
The workflow ARN should be correct according to the CLI, and yeah, $ aws imagebuilder get-workflow --workflow-build-version-arn arn:aws:imagebuilder:eu-west-1:aws:workflow/build/build-image/1.0.1 | jq '.workflow | .arn'
"arn:aws:imagebuilder:eu-west-1:aws:workflow/build/build-image/1.0.1/1"
$ aws imagebuilder get-workflow --workflow-build-version-arn arn:aws:imagebuilder:eu-west-1:aws:workflow/build/build-image/1.0.1/1 | jq '.workflow | .arn'
"arn:aws:imagebuilder:eu-west-1:aws:workflow/build/build-image/1.0.1/1" |
But I would agree with @pahud, the synthesized template looks correct to me, and the workflow ARN is also correct according to the API. I would open an issue with https://github.com/aws-cloudformation/cloudformation-coverage-roadmap, there's not much we can do on the CDK end |
Hi @nmussy - yes I ran that same awscli and got the same result but well - always good to confirm with the "keymaker" :) In the meantime, link to the CloudFormation case: aws-cloudformation/cloudformation-coverage-roadmap#2016 |
Hey @nmussy, @pahud , just to give some feedback. Looks like the CloudFormation documentation is not clear about the Workflows. Thank you for looking into this problem. Closing this. PS: I really like CDK and CF but, I pick too many issues like this API/Documentation mismatch between CloudFormation/CDK and honestly I think this gives a bad reputation to CDK. Kind regards, |
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Describe the bug
I am defining a default Amazon-managed AMI build workflow (arn:aws:imagebuilder:eu-west-1:aws:workflow/build/build-image/1.0.1/1) but it breaks.
The snippet of code I am using: (reduced to the essential):
Expected Behavior
Build a image pipeline using a standard workflow.
Current Behavior
Reproduction Steps
As show above, the deployment of the following resource; using workflows.
Possible Solution
No response
Additional Information/Context
The official CloudFormation page https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-imagebuilder-imagepipeline-workflowconfiguration.html#cfn-imagebuilder-imagepipeline-workflowconfiguration-workflowarn points out the correct regexp for this parameter:
In the meantime just for testing the pattern I've used in TS, (using https://regex101.com/ to test the regexp), I had to escape all "/" like following bellow to get it working; in any case the deployment failed.
The text was updated successfully, but these errors were encountered: