core: suppressTemplateIndentation option not supported in NestedStackProps

[Laxenade]

Describe the feature

I'm working on creating a nested stack with a template that is larger than 1MB (it's currently at 3.1MB). After reviewing #25892, it appears that efforts have been made to reduce the size of the main stack's template. It would be beneficial to have a similar feature for nested stacks.

Use Case

The rationale for implementing this feature is essentially the same as the reasons for minifying the main stack's template. This also helps keep the experience consistent between Stack and NestedStack.

Proposed Solution

The required code change appears to be fairly straightforward, closely resembling the changes made in the original pull request.

Place to change:

aws-cdk/packages/aws-cdk-lib/core/lib/nested-stack.ts

Line 223 in e1e973b

const cfn = JSON.stringify(this._toCloudFormation());

Relevant changes from previous PR:

aws-cdk/packages/aws-cdk-lib/core/lib/stack.ts

Line 1077 in e1e973b

const indent = this._suppressTemplateIndentation ? undefined : 1;

The same context key can be re-used and the new option is NestedStackProps can have the same name as the one in StackProps: suppressTemplateIndentation

Other Information

No response

Acknowledgements

• I may be able to implement this feature request
• This feature might incur a breaking change

CDK version used

2.96.1

Environment details (OS name and version, etc.)

MacOS 13.6.3

[Laxenade]

Looking into the issue further, it's weird to me that the code in NestedStack already omits the spaces, since no parameter was given to stringify. Yet, the generated template of my nested stacks is still indented by 1 space.

aws-cdk/packages/aws-cdk-lib/core/lib/nested-stack.ts

Line 223 in e1e973b

const cfn = JSON.stringify(this._toCloudFormation());

Sample generated nested stack template:

{
 "Resources": {
  "<some logical id>": {
   "Type": "AWS::CloudWatch::Dashboard",
   "Properties": {
    "DashboardBody": {
     "Fn::Join": [
      "",
      [
       "{\"start\":\"-PT3H\",\"periodOverride\":\"inherit\",\"widgets\":[{\"type\":\"text\",\"width\":24,\"height\":3,\"x\":0,\"y\":0,\"properties\":{\"markdown\":\"| Environment| AWS Account| AWS Console| Pipeline\\n|---|---|---|---\\n

[Laxenade]

Nvm, I re-built my CDK from scratch, the nested stacks did respect suppressTemplateIndentation. Closing.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.