Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: check construct id and name length #28551

Closed
2 tasks
mhintz-clickup opened this issue Jan 2, 2024 · 2 comments
Closed
2 tasks

all: check construct id and name length #28551

mhintz-clickup opened this issue Jan 2, 2024 · 2 comments
Labels
@aws-cdk/aws-kms Related to AWS Key Management closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@mhintz-clickup
Copy link

Describe the feature

Run into issues all the time where there is a cap on ID's from roles, kms keys, etc.
CDK should be aware of this and be able to detect when these will happen.
Not sure if this happens with construct ID length but pretty sure I've seen it happen in the past. I mostly see it with KMS key names, Role names, and a few other resources.

Use Case

Create a new role with some variables in it (like region or account name).
When using projen (or just cdk) and doing a "build" (or synth, lint, etc.) then cdk will check on name lengths.

Proposed Solution

When using projen (or just cdk) and doing a "build" (or synth, lint, etc.) then cdk will check on name lengths.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

latest

Environment details (OS name and version, etc.)

Linux

@mhintz-clickup mhintz-clickup added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 2, 2024
@github-actions github-actions bot added the @aws-cdk/aws-kms Related to AWS Key Management label Jan 2, 2024
@tim-finnigan
Copy link

Thanks for the feature request. Could you provide specific steps/code to reproduce the issue? I'm wondering if this is something similar to #3402. I'd expect the limits to be consistent with whatever the services have defined, for example with KMS: https://docs.aws.amazon.com/kms/latest/APIReference/API_KeyMetadata.html

@tim-finnigan tim-finnigan self-assigned this Jan 3, 2024
@tim-finnigan tim-finnigan added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. labels Jan 3, 2024
@tim-finnigan tim-finnigan removed their assignment Jan 3, 2024
@tim-finnigan tim-finnigan added p2 effort/medium Medium work item – several days of effort labels Jan 3, 2024
Copy link

github-actions bot commented Jan 5, 2024

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-kms Related to AWS Key Management closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

2 participants