Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-apigatewayv2: cannot find HttpLambdaIntegration switching from deprecated alpha package #28239

Closed
jrobbins-LiveData opened this issue Dec 3, 2023 · 3 comments · Fixed by #28250
Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 bug This issue is a bug.

Comments

@jrobbins-LiveData
Copy link
Contributor

Describe the bug

In version 2.113.0 using aws-cdk.aws-apigatewayv2-alpha and aws-cdk.aws-apigatewayv2-integrations-alpha (in Python 3.11), I see deprecation warnings. Yet when I tried to switch from alpha to aws_apigatewayv2, I was unable to locate the "integrations".

I don't see a separate "integrations" module in the whl file
image

Where, for example, can I find the HttpLambdaIntegration construct (or its successor)?

Expected Behavior

Since the apigateway v2 alpha packages are deprecated, e.g. this output appears now when I use CDK deploy

[WARNING] @aws-cdk/aws-apigatewayv2-integrations-alpha.HttpLambdaIntegration is deprecated.

I expect to be able to edit my CDK stack code to use a non-deprecated equivalent.

Current Behavior

I was unable to locate the non-deprecated equivalent.

Reproduction Steps

Deploy a CDK stack written in Python that uses this construct

        apigw = apigwv2.HttpApi(
            self, 'ExternalApi',
            default_integration=HttpLambdaIntegration('DefaultIntegration', lambda_function),
            default_domain_mapping=apigwv2.DomainMappingOptions(domain_name=dn)
        )

You should see the deprecation message output.

Possible Solution

I don't know if this is a documentation bug/oversight/not-yet-updated, or if there's some code not making it into the Python version.

This chore makes it sound like I should be able to find what I need.

Additional Information/Context

No response

CDK CLI Version

2.113.0 (build ccd534a)

Framework Version

No response

Node.js Version

v18.17.1

OS

Edition Windows 10 Pro Version 22H2 Installed on ‎5/‎1/‎2021 OS build 19045.3693 Experience Windows Feature Experience Pack 1000.19053.1000.0

Language

Python

Language Version

Python 3.11.6 (tags/v3.11.6:8b6ee5b, Oct 2 2023, 14:57:12) [MSC v.1935 64 bit (AMD64)] on win32

Other information

No response

@jrobbins-LiveData jrobbins-LiveData added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 3, 2023
@github-actions github-actions bot added the @aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 label Dec 3, 2023
@Dreamescaper
Copy link

Same with dotnet nuget package.

@jgreenbow
Copy link
Contributor

It appears that the modules are not exported as part of the main index file. I have added a PR for this. Still not sure if there are other changes required for these modules to be made available. Currently rolled back to v2.111.0

#28250

@khushail khushail added the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Dec 4, 2023
@mergify mergify bot closed this as completed in #28250 Dec 4, 2023
mergify bot pushed a commit that referenced this issue Dec 4, 2023
The API Gateway V2 modules which were graduated to stable with [2.112.0](https://github.com/aws/aws-cdk/releases/tag/v2.112.0) were not added to the main package exports. In particular:

- aws-apigatewayv2-authorizers
- aws-apigatewayv2-integrations

Closes #28239.

Now, I am not completely familiar with JSII and the CDK, so this may be only one part of the required solution to include these missing packages. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Copy link

github-actions bot commented Dec 4, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

chenjane-dev pushed a commit to chenjane-dev/aws-cdk that referenced this issue Dec 5, 2023
…8250)

The API Gateway V2 modules which were graduated to stable with [2.112.0](https://github.com/aws/aws-cdk/releases/tag/v2.112.0) were not added to the main package exports. In particular:

- aws-apigatewayv2-authorizers
- aws-apigatewayv2-integrations

Closes aws#28239.

Now, I am not completely familiar with JSII and the CDK, so this may be only one part of the required solution to include these missing packages. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@khushail khushail removed investigating This issue is being investigated and/or work is in progress to resolve the issue. needs-triage This issue or PR still needs to be triaged. labels Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 bug This issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants