Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lambda-nodejs): add verbose and debug log level to esbuild bundling #27658

Merged
merged 3 commits into from
Nov 27, 2023
Merged

feat(lambda-nodejs): add verbose and debug log level to esbuild bundling #27658

merged 3 commits into from
Nov 27, 2023

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Oct 24, 2023 •
edited
Loading

Official log levels are here.

Closes #27634.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 24, 2023 00:39
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 admired-contributor [Pilot] contributed between 13-24 PRs to the CDK labels Oct 24, 2023
@msambol
Copy link
Contributor Author

msambol commented Oct 24, 2023

@dreamorosi I also added DEBUG to round out the set.

aws-cdk-automation
aws-cdk-automation previously requested changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review October 24, 2023 00:44

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 24, 2023
laurelmay
laurelmay approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@laurelmay laurelmay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these and making sure they're covered by tests.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Oct 26, 2023
@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Closed
@SankyRed SankyRed self-assigned this Nov 8, 2023
@msambol
Copy link
Contributor Author

msambol commented Nov 27, 2023

@SankyRed Can I nudge you for a review here?

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1f1fe5b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

SankyRed
SankyRed approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@SankyRed SankyRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for contributing @msambol

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d5ef107 into aws:main Nov 27, 2023
10 checks passed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SankyRed SankyRed SankyRed approved these changes

@laurelmay laurelmay laurelmay approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

@SankyRed SankyRed

Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-cdk-lib/aws-lambda-nodejs: add VERBOSE log level to esbuild bundling
4 participants
@msambol @aws-cdk-automation @laurelmay @SankyRed