Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-cdk-lib: to use nodejs18 #26901

Closed
2 tasks
beaumsc opened this issue Aug 27, 2023 · 11 comments
Closed
2 tasks

aws-cdk-lib: to use nodejs18 #26901

beaumsc opened this issue Aug 27, 2023 · 11 comments
Labels
aws-cdk-lib Related to the aws-cdk-lib package feature-request A feature should be added or improved. node18-upgrade Any work (bug, feature) related to Node 18 upgrade response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@beaumsc
Copy link

beaumsc commented Aug 27, 2023

Describe the feature

As a python developer wishing to use cdk for python, I want common services built by the cdk using NodeJS to be based on a non-deprecated version of NodeJS and certainly not version 14 which is soon to be unsupported by AWS.

Given latest version version of cdk installed
When cdk init app --language python is issued on a new folder
And pip install -r requirements.txt is issued
Then all references to runtime=" for installed files within .../.venv/lib/python3.x/site-packages/aws_cdk/ specify NODEJS_18_X

Use Case

I want to use cdk for my AWS deployments and this will soon not be possible [1].

[1] https://endoflife.date/nodejs

Proposed Solution

NodeJS v18

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.93.0

Environment details (OS name and version, etc.)

Linux (WSL2)

@beaumsc beaumsc added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 27, 2023
@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label Aug 27, 2023
@peterwoodworth
Copy link
Contributor

If you could let us know what is not using node18 yet that would be helpful - we have migrated most if not everything to node18

@peterwoodworth peterwoodworth added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. labels Aug 28, 2023
@peterwoodworth
Copy link
Contributor

I think all that's still left is just one custom resource handler found in Route 53 - All our other functions should be on Node 18, unless I'm misunderstanding the issue @beaumsc

@peterwoodworth peterwoodworth added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Aug 29, 2023
@github-actions
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Aug 31, 2023
@msheiny
Copy link

msheiny commented Sep 1, 2023

I think all that's still left is just one custom resource handler found in Route 53 - All our other functions should be on Node 18, unless I'm misunderstanding the issue @beaumsc

Hey which CR handler is still on nodejs14? Just want to check if I'm using it and keep tabs on it so I can upgrade when it bumps. Thanks for the work ya'll do ❤️

@khushail khushail added the node18-upgrade Any work (bug, feature) related to Node 18 upgrade label Sep 1, 2023
@github-actions github-actions bot removed closing-soon This issue will automatically close in 4 days unless further comments are made. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Sep 1, 2023
@khushail
Copy link
Contributor

khushail commented Sep 1, 2023

Hi @beaumsc , it would be helpful if you could share which custom resource handler is on nodejs14, as our team is working on this update

@khushail khushail added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Sep 1, 2023
@beaumsc
Copy link
Author

beaumsc commented Sep 3, 2023

@msheiny @khushail
The building of the singletonLambda is being deployed as a NodeJS14 runtime as result of of cdk boostrap is my specific issue. However, when I search the installed python library into my virtual environment for runtime version ("runtime=" search string, see description for suggested BDD test for this issue), I can see this issue extends beyond just the singletonLambda common resource code, NODEJS14 is mentioned in 10+ other places.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Sep 3, 2023
@iliapolo
Copy link
Contributor

iliapolo commented Sep 4, 2023

@beaumsc what exactly do you mean by singletonLambda? Can you please share more specific identifiers?

Also it would be helpful if you can share the results of your search? I'm not able to find the occurrences you are mentioning...

@iliapolo iliapolo added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Sep 4, 2023
@iliapolo iliapolo assigned iliapolo and unassigned iliapolo Sep 4, 2023
@beaumsc
Copy link
Author

beaumsc commented Sep 5, 2023

@iliapolo,

in answer to your question, when deploying my CDK defined app, more specifically, after running cdk bootstrap, one of the resultant resources in cloudformation is a Lambda with logical ID of SingletonLambda.

The following docker file isolates the issues, it outputs 95 references to NODEJS14

FROM python:3.10-slim

RUN pip install aws-cdk-lib==2.93.0

WORKDIR /usr/local/lib/python3.10/site-packages
CMD grep -r -H -n --include \*.py Runtime.NODEJS_14 aws_cdk

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Sep 6, 2023
@pahud
Copy link
Contributor

pahud commented Sep 6, 2023

@beaumsc

Try using 2.94.0 instead. You will not grep anything. See below:

image

@pahud pahud added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Sep 6, 2023
@beaumsc
Copy link
Author

beaumsc commented Sep 6, 2023

@pahud,

I concur, when upgrading to aws-cdk-lib 2.94.0

  1. cdk boostrap replaced my SingletonLambda deployment to use Nodejs-18 runtime.
  2. There are no references to version 14

FYI, there are 32 references to nodejs version 16.

Thanks for resolving, great job. 👏

@beaumsc beaumsc closed this as completed Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-cdk-lib Related to the aws-cdk-lib package feature-request A feature should be added or improved. node18-upgrade Any work (bug, feature) related to Node 18 upgrade response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

7 participants
@pahud @iliapolo @msheiny @beaumsc @peterwoodworth @khushail and others