(ci): make logs of PR GitHub CI public instead of using github-codebuild-logs

[trivikr]

Describe the feature

Make logs of PR GitHub CI public instead of using github-codebuild-logs

Use Case

The AWS CodeBuild supports publicly viewable build results. When enabled, the build results are accessible to public.

The CodeBuild used by aws-cdk is private, and it uses github-codebuild-logs to add a comment with link to the result. Because of this, and an extra comment is added for each CI build.

Example comment: #26624 (comment)

Proposed Solution

Enable publicly viewable build results on CodeBuild, and disable github-codebuild-logs.

Other Information

No response

Acknowledgements

• I may be able to implement this feature request
• This feature might incur a breaking change

CDK version used

N/A

Environment details (OS name and version, etc.)

N/A

[pahud]

Current build log should be public viewable already such as #26624 (comment) but yeah it would be great to use the build-in public viewable build results support.

[peterwoodworth]

How would this improve the experience?

[trivikr]

How would this improve the experience?

The PR author, or anyone viewing the PR, can click on "Details" to view the CodeBuild Logs as they would appear in Console.

In current experience, the person clicks on Details which attempts to open CodeBuild Logs and fails if you're not logged in with the AWS account running the CodeBuild.

Then the person needs to read the extra comment added by github-codebuild-logs, and open the logs as raw text.

[peterwoodworth]

I understand the request, I don't understand how switching which button you need to press to view the logs improves anything. Did you or someone else get confused at how to view the logs?

[trivikr]

Did you or someone else get confused at how to view the logs?

I clicked on "Details" in CI failure before the github-codebuild-logs comment was posted. It's just additional learning.

I'm maintainer of AWS SDK for JavaScript. We also used github-codebuild-logs pre-2021 when CodeBuild did not have publicly viewable build results. When CodeBuild introduced the feature, we switched to it and removed github-codebuild-logs.

• Example PR from Feb'20 chore: codegen for switch to fast-xml-parser aws-sdk-js-v3#819
  • Notice it has one outdated comment from github-codebuild-logs per commit.
• Example PR from today fix(token-providers): break dependency cycle with sso-oidc aws-sdk-js-v3#5049
  • No comment from github-codebuild-logs. CodeBuild Logs can be accessed from GitHub interface.

The recommendation is for AWS CDK to also switch to publicly viewable build results, so that it's easier for new visitors and future contributors. If it's too much work, feel free to close it as not planned.