Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acm: reliability improvements for automatically validated certificate #2632

Closed
rix0rrr opened this issue May 24, 2019 · 2 comments
Closed

acm: reliability improvements for automatically validated certificate #2632

rix0rrr opened this issue May 24, 2019 · 2 comments
Assignees
Labels
@aws-cdk/aws-certificatemanager Related to Amazon Certificate Manager effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented May 24, 2019

Remarks from Todd Cignetti:

  • One thing that’s important to call out in the docs is what happens in the case of a partial failure to write to R53. For example, for a certificate request with multiple domains, some writes to R53 may succeed and others may fail. I presume that the call would fail, but it would not remove the records that it wrote successfully. The good news is that a subsequent call to ACM from the same account with the same domains will generate the same R53 tokens, so repeating the call can be successful.

  • Another question is how to maintain the R53 records in conjunction with the cert lifecycle. It would be nice to have a call to remove the records when all of the certificates that use the domain are deleted. Obviously there could be issues here where a domain is still in use with one certificate when another cert that uses the domain is deleted, so it’s not ok just to delete the tokens from R53 when a certificate with that domain is deleted.

@rix0rrr rix0rrr added the feature-request A feature should be added or improved. label May 24, 2019
@rix0rrr rix0rrr added the @aws-cdk/aws-certificatemanager Related to Amazon Certificate Manager label Jan 23, 2020
@rix0rrr rix0rrr assigned skinny85 and unassigned rix0rrr Jan 23, 2020
@skinny85 skinny85 added the effort/large Large work item – several weeks of effort label Feb 6, 2020
@SomayaB SomayaB assigned njlynch and unassigned skinny85 Jul 10, 2020
@njlynch njlynch added the p2 label Aug 11, 2020
@njlynch
Copy link
Contributor

njlynch commented Dec 2, 2020

Closing this out.

The first bullet point is addressed by the Javascript SDK's built-in retry mechanism for DnsValidatedCertificate and by the CloudFormation implementation for Certificate. The second point is tracked by #3333, #11201, and #7063.

@njlynch njlynch closed this as completed Dec 2, 2020
@github-actions
Copy link

github-actions bot commented Dec 2, 2020

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-certificatemanager Related to Amazon Certificate Manager effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

3 participants