Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(custom-resources): (use lambda.Runtime.NODEJS_18_X by default in Provider) #25021

Closed
1 of 2 tasks
rajaravi1 opened this issue Apr 11, 2023 · 3 comments
Closed
1 of 2 tasks

(custom-resources): (use lambda.Runtime.NODEJS_18_X by default in Provider) #25021

rajaravi1 opened this issue Apr 11, 2023 · 3 comments
Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources feature-request A feature should be added or improved. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@rajaravi1
Copy link

Describe the feature

Similar to #19117 we should update to latest supported Node.js runtime for the custom-resources lambda prior to Node 14 going eol.

Use Case

All lambdas created by aws-cdk internally should be updated prior to EOL.

Proposed Solution

Update to NODEJS_18_X when creating lambda in custom-resources.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.29.1

Environment details (OS name and version, etc.)

Mac 13.3.1 (22E261)
@rajaravi1 rajaravi1 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 11, 2023
@github-actions github-actions bot added the @aws-cdk/custom-resources Related to AWS CDK Custom Resources label Apr 11, 2023
@pahud
Copy link
Contributor

pahud commented Apr 11, 2023

I am afraid we can't all in nodejs 18 for now. See #24725 (comment)

@pahud pahud added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. p2 and removed needs-triage This issue or PR still needs to be triaged. labels Apr 11, 2023
@peterwoodworth
Copy link
Contributor

You've seemed to have exactly duplicated this issue #23682

@peterwoodworth peterwoodworth closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2023
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources feature-request A feature should be added or improved. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pahud @peterwoodworth @rajaravi1