Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(integ-tests): awsApiCall will call the API twice in deletion as well #22361

Closed
iriskraja77 opened this issue Oct 5, 2022 · 2 comments
Closed
Assignees
Labels
@aws-cdk/assertions Related to the @aws-cdk/assertv2 package bug This issue is a bug.

Comments

@iriskraja77
Copy link

Describe the bug

integTest.assertions.awsApiCall will call the specified API Call twice: once on stack creation, and another time on stack deletion.
This can be a problem for API Calls with write actions.

Expected Behavior

The specified API is only called once on stack creation.

Current Behavior

The specified API is called twice, on stack deletion as well.

Reproduction Steps

Simply specify any API and monitor CloudWatch Logs of the integ-test provider function.

Possible Solution

Only call the API in cloudformation stack creation event.

Additional Information/Context

No response

CDK CLI Version

2.41.0

Framework Version

2.41.0

Node.js Version

16.15.1

OS

MacOS

Language

Typescript

Language Version

No response

Other information

No response

@iriskraja77 iriskraja77 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 5, 2022
@github-actions github-actions bot added the @aws-cdk/assertions Related to the @aws-cdk/assertv2 package label Oct 5, 2022
@corymhall
Copy link
Contributor

@iriskraja77 this was recently fixed in #22238 so it should be released in the next version of CDK which should release in the next couple of days.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/assertions Related to the @aws-cdk/assertv2 package bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

4 participants