Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding custom attributes on ECS container instances #1772

Closed
SoManyHs opened this issue Feb 14, 2019 · 3 comments
Closed

Support adding custom attributes on ECS container instances #1772

SoManyHs opened this issue Feb 14, 2019 · 3 comments
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@SoManyHs
Copy link
Contributor

Currently, the ECS Cluster construct does not support adding custom attributes on container instances. These would be necessary for for specifying a memberOf placement constraint. using the cluster query language for custom attributes. https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-placement-constraints.html

@SoManyHs SoManyHs added @aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved. labels Feb 14, 2019
@rix0rrr
Copy link
Contributor

rix0rrr commented Oct 30, 2019

Still relevant

@rix0rrr rix0rrr assigned MrArnoldPalmer and unassigned rix0rrr Jan 23, 2020
@MrArnoldPalmer MrArnoldPalmer added effort/small Small work item – less than a day of effort p2 labels Mar 14, 2020
@SoManyHs SoManyHs added the good first issue Related to contributions. See CONTRIBUTING.md label May 5, 2020
@allisaurus allisaurus self-assigned this May 5, 2020
@allisaurus
Copy link
Contributor

allisaurus commented May 5, 2020

Looks like setting custom attributes needs to be done at registration time by setting ECS_INSTANCE_ATTRIBUTES via user data, similar to how cluster name and spot draining is configured.

Two concerns with this:

  1. setting via user data means adding/changing them will require replacing the instances :/
  2. you can add up to 10 attributes to an instance, and generating/interpolating that into a user data string like we're doing for cluster names seem rather clunky. May want to instead leverage whatever solution is found for Enable adding custom user data to ECS cluster #1711

@SoManyHs SoManyHs added effort/medium Medium work item – several days of effort and removed effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md labels May 5, 2020
@allisaurus allisaurus removed their assignment May 5, 2020
@allisaurus
Copy link
Contributor

Since this will be possible after #1711 is addressed, closing as a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

4 participants