aws-route53-targets: LoadBalancerTarget always appends the dualstack prefix even when not a valid option

[epalace510]

What is the problem?

When fixing #6271 with #8747, you enforced that all load balancer targets start with the dualstack prefix. Network Load Balancers (NLBs) have 2 IP Address types you can configure, IPv4 or dualstack (this was launched late last year). The default for the property is IPv4, and the CDK definition doesn't even allow for the option to be set. When NLB is set to IPv4, it does not have a dualstack prefix you can route to. This means the generated ARecords don't work; they target a non-existent DNS record.

Reproduction Steps

I'm going to leave the class instantiation out, but you can assume this is within a construct.

this.hostedZone = new route53.HostedZone(this, "ExampleHostedZone", {
    zoneName: props.hostedZoneName,
});

this.vpc = new ec2.Vpc(this, "ExampleVPC");

this.loadBalancer = new elasticloadbalancingv2.NetworkLoadBalancer(this, "ExampleNLB", {
  vpc: this.vpc,
});

new aws-route53.ARecord(this,
  "LoadBalancerAlias",
  {
    zone: this.hostedZone,
    target: aws-route53.RecordTarget.fromAlias(
      new aws-route53-targets.LoadBalancerTarget(this.loadBalancer)
    ),
    comment: "A-Record to route traffic to the service Load Balancer",
  }
);

What did you expect to happen?

I expected a valid Alias ARecord to my NLB.

What actually happened?

The CDK incorrectly prefixed dualstack to my NLB DNS name, causing the service to be unreachable.

CDK CLI Version

1.125.0

Framework Version

No response

Node.js Version

12

OS

AmazonLinux 2

Language

Typescript

Language Version

No response

Other information

The NLB IPAddressType is a configurable property of the Cfn definition https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-elasticloadbalancingv2-loadbalancer.html#cfn-elasticloadbalancingv2-loadbalancer-ipaddresstype

[larryboymi]

I'm also running into this issue. @epalace510 did you figure out a workaround?

In my case I'm creating an NLB-specific version of https://github.com/aws/aws-cdk/blob/v1.134.0/packages/@aws-cdk/aws-route53-targets/lib/load-balancer-target.ts

[skyzenr]

Same issue also with CDK v2.

[epalace510]

@larryboymi I wrote a class to do what I needed. It's not my preferred solution, but it unblocked me.

import { AliasRecordTargetConfig, IAliasRecordTarget, IHostedZone, IRecordSet } from "monocdk/aws-route53";
import { NetworkLoadBalancer } from "monocdk/aws-elasticloadbalancingv2";

/**
 * Use an ELB Network Load Balancer as an alias record target.
 * This NLB specific target was written because CDK will always prepend
 * `dualstack` to the DNS name which is not always valid for NLBs.
 * https://github.com/aws/aws-cdk/issues/16987
 */
export class NetworkLoadBalancerTarget implements IAliasRecordTarget {
    private readonly loadBalancer: NetworkLoadBalancer;

    constructor(loadBalancer: NetworkLoadBalancer) {
      this.loadBalancer = loadBalancer;
    }

    /**
     * Return hosted zone ID and DNS name, usable for Route53 alias targets.
     */
    bind(_record: IRecordSet, _zone?: IHostedZone): AliasRecordTargetConfig {
      return {
        hostedZoneId: this.loadBalancer.loadBalancerCanonicalHostedZoneId,
        dnsName: this.loadBalancer.loadBalancerDnsName,
      };
    }
}

[larryboymi]

@epalace510 yep that's exactly what my class looked like

[flaksirus]

I'm facing exactly the same issue.

[github-actions]

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.