Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-certificatemanager): DnsValidatedCertificate should support RemovalPolicy #15871

Closed
1 of 2 tasks
bradleyv8 opened this issue Aug 3, 2021 · 4 comments
Closed
1 of 2 tasks
Labels
@aws-cdk/aws-certificatemanager Related to Amazon Certificate Manager effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@bradleyv8
Copy link

DnsValidatedCertificate currently does not support the application of a RemovalPolicy. Without this, the certificates default to "Delete". If we want to Retain them, this doesn't seem possible without resorting to ugly syntax like referencing the node children directly.

Use Case

We want to be able to specify the removal policy on certificates created via DnsValidatedCertificate.

Proposed Solution

new acm.DnsValidatedCertificate(this, "domain_cert", {
  domainName: serviceDomainName,
  hostedZone: hostedZone,
  validation: acm.CertificateValidation.fromDns(hostedZone),
  region: "us-east-1" : env.region,
  removalPolicy: RemovalPolicy.RETAIN
});
  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@bradleyv8 bradleyv8 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 3, 2021
@github-actions github-actions bot added the @aws-cdk/aws-certificatemanager Related to Amazon Certificate Manager label Aug 3, 2021
@bradleyv8
Copy link
Author

I've made a change to add a removalPolicy prop to DnsValidatedCertificateProps and apply this to the certificate which is created inside the resource. I'm happy to submit a PR for this if this approach is acceptable.

@njlynch
Copy link
Contributor

njlynch commented Aug 10, 2021

Sure, happy to review a PR for this addition, @bradleyv8 .

@njlynch njlynch added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Aug 10, 2021
@njlynch njlynch removed their assignment Aug 10, 2021
@peterwoodworth
Copy link
Contributor

Closing this as a duplicate of #20649

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-certificatemanager Related to Amazon Certificate Manager effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

3 participants