Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(@aws-cdk/aws-dynamodb): CMK should be supported with Global dynamo db #15258

Closed
vishleshpatel opened this issue Jun 22, 2021 · 7 comments
Closed
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB effort/medium Medium work item – several days of effort feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. p2

Comments

@vishleshpatel
Copy link

vishleshpatel commented Jun 22, 2021

description of the bug:

CDK throws error when Global Dynamo DB is used with CMK.

Error: TableEncryption.CUSTOMER_MANAGED is not supported by DynamoDB Global Tables (where replicationRegions was set)

Reproduction Steps

What did you expect to happen?

build Global Dynamo DB with CMK.

What actually happened?

Resource creation failed with : TableEncryption.CUSTOMER_MANAGED is not supported by DynamoDB Global Tables (where replicationRegions was set)

Environment

  • CDK CLI Version :
  • Framework Version:
  • Node.js Version:
  • OS :
  • Language (Version):

Other


This is 🐛 Bug Report

@vishleshpatel vishleshpatel added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jun 22, 2021
@github-actions github-actions bot added the @aws-cdk/aws-dynamodb Related to Amazon DynamoDB label Jun 22, 2021
@skinny85
Copy link
Contributor

Hey @vishleshpatel ,

thanks for opening the issue, but I actually believe this is a DynamoDB limitation. Do you have some documentation that says this should work?

Thanks,
Adam

@skinny85 skinny85 added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jun 23, 2021
@vishleshpatel
Copy link
Author

@skinny85 skinny85 added effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs p2 effort/medium Medium work item – several days of effort and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. effort/large Large work item – several weeks of effort labels Jun 23, 2021
@skinny85
Copy link
Contributor

Thanks for the info @vishleshpatel. Marking this as a feature request. If you'd be interested in contributing it, that would be awesome! Here's our "Contributing" guide: https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md.

@vedsarkushwaha
Copy link

Any ETA when this can be done?

@skinny85
Copy link
Contributor

We don't have this task in our immediate plans @vedsarkushwaha. PRs are definitely welcome.

@peterwoodworth
Copy link
Contributor

Closing in favor of #15957

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB effort/medium Medium work item – several days of effort feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

4 participants