-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GovCloud -> Specified bucket does not exist #1459
Comments
It appears this is due to the way that AWS names the govcloud buckets and has aliases to resources... |
Interesting. From a cursory code review, this shouldn't happen. Could you go into CloudFormation and check the outputs of the |
@rix0rrr And if I'm understanding correctly, the BucketDomainName should be: |
Yes! The silly thing is, it seems to be a CloudFormation issue. The content of the CDKToolkit template should be this:
Which means we're asking CloudFormation for the domain name, and it's returning the wrong name. |
@rix0rrr Is there anyway for me to override this such that I can actually use cdk to do my deployment? I've tried using Thanks for the quick responses! |
You can try changing the CDKToolkit template and change it to something like the following:
I.e., construct the right Output value manually. It might be that this change will not deploy since CloudFormation usually doesn't deploy templates if the only thing that changed are the Outputs. In that case, add an
|
@rix0rrr Would it be possible to use the Also, I'll give that a go, thanks! |
Yeah you can also try using |
Ah, no that's internal. Pass This is part of some internal infrastructure that we unfortunately haven't been able to deploy to GovCloud yet. |
Okay thanks! Sorry I deleted the comment, because I thought I did something wrong. Let me give that a go! |
Cool, that got me beyond the issues I made this ticket for. Now i'm just getting some about my API Gateway spec, time to debug! Thanks a bunch @rix0rrr. And just as an overview of this thread:
Just as a question for how updating on this repository goes, are you going to make a change for the RegionalDomainName in the toolkit? Or is that something I should try to create a pull request for? This is an amazing utility and I want to help make it better however I can (even with small changes!) Thanks again for your assistance! |
Thanks for the kind words :). I made a ticket for the first issue: #1469 It's probably a matter of changing the CFN code in this file: https://github.com/awslabs/aws-cdk/blob/master/packages/aws-cdk/lib/api/bootstrap-environment.ts, but warrants some additional testing. Can't promise we'll get around to it quickly, if you want to give it a shot you're more than welcome to! |
@rix0rrr Awesome thanks! And yes this definitely warrants testing in different regions... S3 buckets can be strange! Thanks for the workaround in the meantime though! |
I think I will close this issue, as it seems there is no actionable work left. Feel free to reopen (or file a new one) if you run into more GovCloud issues. Unfortunately, I predict some more issues with ServicePrincipals similar to the issues in China. |
@rix0rrr Any planned updates on this issue? This is still blocking Chinese regions users to use CDK, unless change the file by hand, which is bad practice as CDK is iterating rather rapidly. |
Editing, then, rerun |
@rix0rrr
I checked my S3 bucket found the Is there any way to change this URL in the code or via a plugin? Like some serverless plugin, I read the API document but not found any methods. |
I'm trying to deploy to govcloud using cdk version 0.21.0, and I can get to the point of creating CloudFormation changesets, (the assets/cdk meta is in s3), but then when creating the changeset I get an error: " ❌ TestApi failed: ValidationError: S3 error: The specified bucket does not exist
For more information check http://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html".
Here's the verbose cdk deploy output.
The text was updated successfully, but these errors were encountered: