Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk): add the CodeDeployLambdaAlias Update Policy #1346

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

skinny85
Copy link
Contributor

Fixes #1177.


Pull Request Checklist

Please check all boxes, including N/A items:

Testing

  • Unit test and/or integration test added
  • Toolkit change?: integration tests manually executed (paste output to the PR description)
  • Init template change?: coordinated update of integration tests (currently maintained in a private repo).

Documentation

  • README: README and/or documentation topic updated
  • jsdocs: All public APIs documented

Title and description

  • Change type: Title is prefixed with change type:
    • fix(module): <title> bug fix (patch)
    • feat(module): <title> feature/capability (minor)
    • chore(module): <title> won't appear in changelog
    • build(module): <title> won't appear in changelog
  • Title format: Title uses lower case and doesn't end with a period
  • Breaking change?: Last paragraph of description is: BREAKING CHANGE: <describe exactly what changed and how to achieve similar behavior + link to documentation/gist/issue if more details are required>
  • References: Indicate issues fixed via: Fixes #xxx or Closes #xxx

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@skinny85 skinny85 requested a review from rix0rrr December 13, 2018 01:15
@skinny85 skinny85 requested a review from a team as a code owner December 13, 2018 01:15
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny test?

@skinny85
Copy link
Contributor Author

It will be tested quite extensively when we use it - I'm not sure it's worth a separate test :).

@skinny85 skinny85 force-pushed the feature/lambda-alias-update-policy branch from e887774 to b8ae287 Compare December 13, 2018 23:11
@skinny85
Copy link
Contributor Author

Your silence broke me @eladb . Added a test.

Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be nice if it was possible to have an integration test for this...

@skinny85
Copy link
Contributor Author

I think it'd be nice if it was possible to have an integration test for this...

We will have them when we use this in the Lambda library :)

@skinny85 skinny85 merged commit d648b58 into aws:master Dec 14, 2018
@skinny85 skinny85 deleted the feature/lambda-alias-update-policy branch December 14, 2018 19:48
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model Lambda's Alias.updatePolicy in our AWS::Lambda::Alias L1
4 participants