Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-layer-*): unable to calculate layer asset hash due to missing file #12293

Merged
merged 2 commits into from
Dec 31, 2020

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Dec 31, 2020

The layer/Dockerfile which we use as the source for layer asset hash calculation was excluded from the npm tarball since it was inside the layer directory (which was in .npmignore).

This change de-excludes this file.

Fixes #12291


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…ing file

The `Dockerfile` which we use as the source for layer asset hash calculation was excluded from the npm tarball since it was inside the `layer` directory (which was in .npmignore).

This change de-excludes this file.

Fixes #12291
@gitpod-io
Copy link

gitpod-io bot commented Dec 31, 2020

@eladb eladb requested a review from iliapolo December 31, 2020 07:25
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 31, 2020
@eladb eladb added the pr-linter/exempt-test The PR linter will not require test changes label Dec 31, 2020
@mergify
Copy link
Contributor

mergify bot commented Dec 31, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 646f098 into master Dec 31, 2020
@mergify mergify bot deleted the benisrae/fix-layers branch December 31, 2020 13:41
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 1baec5a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

flochaz pushed a commit to flochaz/aws-cdk that referenced this pull request Jan 5, 2021
…ing file (aws#12293)

The `layer/Dockerfile` which we use as the source for layer asset hash calculation was excluded from the npm tarball since it was inside the `layer` directory (which was in .npmignore).

This change de-excludes this file.

Fixes aws#12291


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

‼️ NOTICE: eks and s3-deployment are broken in v1.81.0
3 participants