fix(core): autogenerated exports do not account for stack name length #11909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autogenerated IDs are limited to 248 characters. However, for exports these are combined with a stack name, which may make the combination exceed the maximum length of 255 characters. Account for the stack name length while generating these IDs. Fixes #9733.
|
|
njlynch
approved these changes
Dec 7, 2020
| let scope: Construct = stack1; | ||
|
|
||
| // WHEN - deeply nested | ||
| for (let i = 0; i < 50; i++) { |
There was a problem hiding this comment.
50 seems a bit excessive; by my math, 17 or so would more than do it. :)
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
skiyani
pushed a commit
to skiyani/aws-cdk
that referenced
this pull request
Dec 7, 2020
…aws#11909) Autogenerated IDs are limited to 248 characters. However, for exports these are combined with a stack name, which may make the combination exceed the maximum length of 255 characters. Account for the stack name length while generating these IDs. Fixes aws#9733. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
flochaz
pushed a commit
to flochaz/aws-cdk
that referenced
this pull request
Jan 5, 2021
…aws#11909) Autogenerated IDs are limited to 248 characters. However, for exports these are combined with a stack name, which may make the combination exceed the maximum length of 255 characters. Account for the stack name length while generating these IDs. Fixes aws#9733. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autogenerated IDs are limited to 248 characters. However, for exports
these are combined with a stack name, which may make the combination
exceed the maximum length of 255 characters.
Account for the stack name length while generating these IDs.
Fixes #9733.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license