Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipelines): wrong runOrder for manual approval when using extraRunOrderSpace #11511

Merged
merged 3 commits into from
Nov 19, 2020

Conversation

adriantaut
Copy link
Contributor

The manual approval action should be right after the Prepare ChangeSet. Fixes #11510


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…cation()

the manual approval action should be right after the Prepare ChangeSet

Fixes aws#11510
@gitpod-io
Copy link

gitpod-io bot commented Nov 17, 2020

…cation()

the manual approval action should be right after the Prepare ChangeSet

Fixes aws#11510
@adriantaut
Copy link
Contributor Author

@rix0rrr would you mind reviewing this one? Thanks a lot 🙇

@rix0rrr rix0rrr changed the title fix(pipelines): support correct order of actions in CdkStage addApplication() fix(pipelines): wrong runOrder for manual approval when using extraRunOrderSpace Nov 19, 2020
@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d4945c7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9b72fc8 into aws:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pipelines] wrong position for ManualApproval action in cdkStage addApplication()
3 participants