Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stepfunctions-tasks): encryption is required for AthenaStartQueryExecution #11355

Merged
merged 5 commits into from
Nov 12, 2020
Merged

fix(stepfunctions-tasks): encryption is required for AthenaStartQueryExecution #11355

merged 5 commits into from
Nov 12, 2020

Conversation

adamdottv
Copy link
Contributor

@adamdottv adamdottv commented Nov 8, 2020 •
edited
Loading

AthenaStartQueryExecution fails to deploy if resultConfiguration.encryptionConfiguration isn't specified. This configuration should be optional.

@adamdottv
fix(stepfunctions-tasks): don't require encryption
5f94720 
AthenaStartQueryExecution fails to deploy if
resultConfiguration.encryptionConfiguration isn't
specified. This configuration should be optional.
@gitpod-io
Copy link

gitpod-io bot commented Nov 8, 2020 •
edited
Loading

@adamdottv adamdottv changed the title fix(stepfunctions-tasks): don't require encryption fix(stepfunctions-tasks): don't require encryption props in AthenaStartQueryExecution Nov 8, 2020
shivlaks
shivlaks previously requested changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamelmore thanks for submitting this fix - had a couple of small suggestions.
let me know if you have any questions or thoughts!!

packages/@aws-cdk/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/lib/athena/start-query-execution.ts Outdated Show resolved Hide resolved
@adamdottv adamdottv requested a review from shivlaks November 9, 2020 19:07
@mergify mergify bot dismissed shivlaks’s stale review November 9, 2020 19:07

Pull request has been modified.

@adamdottv
Copy link
Contributor Author

@shivlaks let me know what you think about these changes!

@shivlaks shivlaks changed the title fix(stepfunctions-tasks): don't require encryption props in AthenaStartQueryExecution fix(stepfunctions-tasks): encryption is required for AthenaStartQueryExecution Nov 10, 2020
shivlaks
shivlaks previously approved these changes Nov 10, 2020
View reviewed changes
@shivlaks
Copy link
Contributor

@adamelmore looks great!!

@mergify mergify bot dismissed shivlaks’s stale review November 10, 2020 08:27

Pull request has been modified.

@adamdottv
Copy link
Contributor Author

@shivlaks I noticed that CodeBuild wasn't finishing, so I merged in latest and all looks green now! Sorry for the dismissal!

@adamdottv adamdottv requested a review from shivlaks November 10, 2020 08:57
@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@shivlaks
Copy link
Contributor

@adamelmore - all good, sorry i missed your message. re-approved!!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 570ec11
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f26a592 into aws:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivlaks shivlaks shivlaks approved these changes

Assignees

@shivlaks shivlaks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamdottv @shivlaks @aws-cdk-automation