Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cfnspec): cloudformation spec v20.0.0 #11319

Merged
merged 10 commits into from
Nov 11, 2020
Merged

Conversation

aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Nov 5, 2020

Following are open issues for missing properties that will be added with the update:

@shivlaks
Copy link
Contributor

shivlaks commented Nov 5, 2020

@PatMyron - ping! we hadn't updated the spec last week - wanted to check in on any patches that need to be applied

@PatMyron
Copy link
Contributor

PatMyron commented Nov 5, 2020

@PatMyron - ping! we hadn't updated the spec last week - wanted to check in on any patches that need to be applied

AWS::MediaPackage::PackagingConfiguration.SpekeKeyProvider
AWS::CodeArtifact::Repository incorrectly marked readOnlyProperties in the resource provider schema

Comment on lines +62737 to +62742
"Attributes": {
"Arn": {
"PrimitiveType": "String"
},
"HlsIngest": {
"Type": "HlsIngest"
Copy link
Contributor

@PatMyron PatMyron Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linking script to find these obscure attribute types

$ curl -s --compressed https://d1uauaxba7bl26.cloudfront.net/latest/gzip/CloudFormationResourceSpecification.json | jq '.ResourceTypes' | jq 'with_entries(.value |= .Attributes)' | grep -v ': null' | grep -Eo 'Type": ".*"' | sort | uniq -c | sort -nr
 582 Type": "String"
  27 Type": "List"
   7 Type": "Integer"
   4 Type": "Boolean"
   1 Type": "Map"
   1 Type": "Json"
   1 Type": "HlsIngest"
   1 Type": "FindingsFilterListItem"
   1 Type": "ConnectionAliasAssociation"

whether those last 3 are intentionally or accidentally those specific types is another question unfortunately

@gitpod-io
Copy link

gitpod-io bot commented Nov 6, 2020

@njlynch njlynch requested a review from a team November 11, 2020 12:25
@njlynch njlynch assigned njlynch and unassigned iliapolo Nov 11, 2020
@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8c17a35 into master Nov 11, 2020
@mergify mergify bot deleted the bump-cfnspec/v20.0.0 branch November 11, 2020 18:27
@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 6c9856a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[transfer] SecurityGroupIds propertie missing in interface EndpointDetailsProperty
5 participants