feat(apigatewayv2): http api - metric methods for api and stage #10686
Conversation
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
cyuste
changed the title
There was a problem hiding this comment.
The issue you've pointed at - #10325 - is referring to apigatewayv2, and not this module. Please provide a proper description in your commit message on what you're looking to achieve here.
If you're looking to add helper metric method to the RestApi construct, this is not done via Cfn augmentation. Instead, it's done explicitly in the source code. See here for examples - https://github.com/aws/aws-cdk/search?q=public+metric
Please also note that there is an open PR on related changes here - #10667
cyuste
changed the title
nija-at
changed the title
|
|
| /** | ||
| * Return the given named metric for this HTTP Api Gateway Stage | ||
| * | ||
| * @default Average over 5 minutes | ||
| */ | ||
| public metric(metricName: string, props?: MetricOptions): Metric { |
There was a problem hiding this comment.
You could apply the same logic as HttpApi of moving this into the interface and creating an abstract HttpStageBase class.
This is entirely optional if you want to skip it.
There was a problem hiding this comment.
As you prefer. Currently I can import an api and get its metrics (created a new test for it) but I can't for a stage, what is correct as I cannot either associate an imported stage to an api and therefore cannot set the metric dimensions.
There was a problem hiding this comment.
It's fine. It can be done later as a separate PR.
Co-authored-by: Niranjan Jayakar <[email protected]>
Co-authored-by: Niranjan Jayakar <[email protected]>
Co-authored-by: Niranjan Jayakar <[email protected]>
Co-authored-by: Niranjan Jayakar <[email protected]>
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
fixes #10325
closes #10726
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license