feat(apigateway): grant methods to ApiKey

[ayush987goyal]

feat(apigateway): Add grant* methods to ApiKey

Ref

close #8060

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[nija-at]

Nice! I like the changes in this PR 🙌

Suggestion:

If you could implement these APIs on a class called ApiKeyBase and then have both ApiKey and the Import class extend this base class, then this functionality is also available to imported keys.

Something like this -

class ApiKeyBase extends Resource implements IApiKey {
   public grantRead(...)  { ... }
   public grantWrite(...) { ... } 
   ...
}

export class ApiKey extends ApiKeyBase {
  public static fromApiKeyId(scope: Construct, id: string, apiKeyId: string): IApiKey {
    class Import extends ApiKeyBase {
      public keyId = apiKeyId;
    }
    return new Import(scope, id);
  }
}

Note that, ApiKeyBase is not exported.

Pull request has been modified.

[ayush987goyal]

Hi @nija-at , you might have to add the pr-readme-exempt label to this one.

[nija-at]

Hi @nija-at , you might have to add the pr-readme-exempt label to this one.

Instead, how about creating a new section called 'Api Key' at line 154 (and in the table of contents)? It feels like lines154-239 are talking about API keys. Then, add a couple of sentences around the grant APIs to that section

[nija-at]

I would prefer not to export ApiKeyBase and I think we don't need an ApiKeyBaseProps.

I've pushed a commit that changes this and restructures the code so the export is not needed. Take a look and let me know what you think.

[ayush987goyal]

I would prefer not to export ApiKeyBase and I think we don't need an ApiKeyBaseProps.

I've pushed a commit that changes this and restructures the code so the export is not needed. Take a look and let me know what you think.

These changes look good to me. Thanks!

Pull request has been modified.

Pull request has been modified.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 9cab702
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).